Option to mention someone#4
Merged
junhwi merged 1 commit intojunhwi:masterfrom Dec 18, 2017
Merged
Conversation
junhwi
approved these changes
Dec 18, 2017
Owner
|
@dahlia Thank you for adding great feature! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for making a useful library!
This patch adds a new option named
mentionwhich purposes to send messages with mentioning someone. If the option is omitted it behaves as like it has done.An example code follows:
A message the above code sent looks like:
Postscript: Although its setup.py indicates the project is licensed under MIT, it would be more clear if the repository contains an explicit LICENSE file as well. GitHub also can recognize the LICENSE file so that it shows project's license on the overview bar.