Allow @Nested test classes to be ordered#2701
Closed
sbrannen wants to merge 4 commits intojunit-team:mainfrom
Closed
Allow @Nested test classes to be ordered#2701sbrannen wants to merge 4 commits intojunit-team:mainfrom
@Nested test classes to be ordered#2701sbrannen wants to merge 4 commits intojunit-team:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2701 +/- ##
==========================================
+ Coverage 91.40% 91.43% +0.02%
==========================================
Files 427 427
Lines 12116 12149 +33
Branches 948 951 +3
==========================================
+ Hits 11075 11108 +33
Misses 801 801
Partials 240 240
Continue to review full report at Codecov.
|
d0531d8 to
96cd909
Compare
Member
Author
|
This PR now includes a new Once this PR has been approved, I will update the release notes and user guide accordingly. |
sormuras
approved these changes
Aug 30, 2021
Member
sormuras
left a comment
There was a problem hiding this comment.
LGTM and should ship with 5.8.0
PR junit-team#2488 introduced support for ordering top-level test classes but did not provide support for ordering @nested test classes. This commit adds support for ordering @nested test classes. See: junit-team#2699
This commit builds on the previous commit by introducing a new @TestClassOrder annotation that can be used to configure a ClassOrderer for @nested test classes. A @TestClassOrder declaration always overrides a globally configured ClassOrderer. See: junit-team#2699
37fc875 to
a8ef251
Compare
Member
Author
|
This has been merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
PR #2488 introduced support for ordering top-level test classes but did not provide support for ordering
@Nestedtest classes.This PR adds support for ordering
@Nestedtest classes as well.Closes: #2699
Definition of Done
@APIannotations