Introduce method filter support in the ConsoleLauncher#3169
Introduce method filter support in the ConsoleLauncher#3169marcphilipp merged 4 commits intojunit-team:mainfrom
Conversation
We originally thought we didn't need an include filter because there's already a way to select particular methods. However, the latter does not allow specifying wildcards so there might be some use cases where it would be beneficial. Team decision: Add both |
|
@marcphilipp Thanks for the feedback, I've added the cli options. |
f03f888 to
2f26377
Compare
marcphilipp
left a comment
There was a problem hiding this comment.
I'm afraid I caused a lot of merge conflicts by introducing subcommands in the ConsoleLauncher recently. The new options should now be added to TestDiscoveryOptionsMixin.FilterOptions instead.
@Sakieye Do you have time to rework the PR?
22210ca to
2b90fd0
Compare
2b90fd0 to
bfc798b
Compare
@marcphilipp I've updated my PR, please help review again |
3fdbe6d to
ba42ab9
Compare
|
@marcphilipp Do you still need this feature? If so, I can update it sometime soon. |
Yes, that'd be great if you're still interested! 👍 |
ba42ab9 to
fbfcb36
Compare
|
@marcphilipp I updated my PR again, please help review |
|
@yhkuo41 Thank you for your contribution! 👍 |
|
My pleasure 😀 |
Issue: #3107
Overview
Solves #3107.
After referring to other Filters (such as TagFilter), I am not sure if I should implement both IncludeMethodFilter and ExcludeMethodFilter, please let me know if I should remove IncludeMethodFilter.
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations