Introduce PreInterruptCallback extension point#3431
Merged
marcphilipp merged 3 commits intojunit-team:mainfrom Oct 29, 2024
Merged
Introduce PreInterruptCallback extension point#3431marcphilipp merged 3 commits intojunit-team:mainfrom
marcphilipp merged 3 commits intojunit-team:mainfrom
Conversation
Contributor
Author
|
I am currently not happy with the change in |
AndreasTu
force-pushed
the
fix_2938
branch
2 times, most recently
from
da26892 to
0c2a0ed
Compare
marcphilipp
requested changes
Oct 15, 2024
Member
marcphilipp
left a comment
marcphilipp
left a comment
There was a problem hiding this comment.
I am currently not happy with the change in
MutableExtensionRegistry. Is there another way to get the current activeExtensionRegistryfrom a currentExtensionContext?
I think we should consider adding a <E extends Extension> List<E> getExtensions(Class<E> extensionType) method to ExtensionContext and storing an ExtensionRegistry as an instance field in the implementations of ExtensionContext. Could you please give that a try?
Contributor
Author
|
@marcphilipp Thanks for the review. And your proposal regarding the |
marcphilipp
requested changes
Oct 16, 2024
marcphilipp
requested changes
Oct 17, 2024
marcphilipp
requested changes
Oct 21, 2024
marcphilipp
requested changes
Oct 23, 2024
Member
marcphilipp
left a comment
marcphilipp
left a comment
There was a problem hiding this comment.
Thanks for making the requested changes! I've requested one additional change and I'd like to discuss the introduction of ExtensionContext.getExtensions (that I suggested) with the team before we merge this.
marcphilipp
requested changes
Oct 25, 2024
Member
marcphilipp
left a comment
marcphilipp
left a comment
There was a problem hiding this comment.
One more thing came out of our team discussion.
Added PreInterruptCallback extension to allow to hook into the @timeout extension before the executing Thread is interrupted. The default implementation of PreInterruptCallback will simply print the stacks of all Thread to System.out. It is disabled by default and must be enabled with: junit.jupiter.execution.timeout.threaddump.enabled = true Issue: junit-team#2938 Co-authored-by: Marc Philipp <mail@marcphilipp.de>
marcphilipp
approved these changes
Oct 29, 2024
marcphilipp
changed the title
Member
|
@AndreasTu Thank you for your contribution! 👍 |
This was referenced Feb 24, 2025
This was referenced Mar 17, 2025
This was referenced Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added PreInterruptCallback extension to allow to hook into the
@Timeoutextension before the executing Thread is interrupted.The default implementation of PreInterruptCallback will simply print the stacks of all Thread to System.out.
It is disabled by default and must be enabled with: junit.jupiter.execution.timeout.threaddump.enabled = true
Issue: #2938
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations