Allow declaring exclusive resources for child nodes#4151
Merged
marcphilipp merged 4 commits intojunit-team:mainfrom Nov 26, 2024
vdmitrienko:#3102_allow_to_inherit_resource_locks
Merged
Allow declaring exclusive resources for child nodes#4151marcphilipp merged 4 commits intojunit-team:mainfrom vdmitrienko:#3102_allow_to_inherit_resource_locks
marcphilipp merged 4 commits intojunit-team:mainfrom
vdmitrienko:#3102_allow_to_inherit_resource_locks
Conversation
1 task
1 task
marcphilipp
requested changes
Nov 25, 2024
Member
marcphilipp
left a comment
There was a problem hiding this comment.
Looks good! I only found some minor things.
Contributor
Author
@marcphilipp thanks for the review 🙂 Updated according to the comments |
marcphilipp
approved these changes
Nov 26, 2024
Member
|
Thank you for your contribution, @vdmitrienko! 👍 After merging, I noticed that the tests were in the wrong package/project so I moved them in c1a976e. |
Contributor
Author
My pleasure!
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #3102
Overview
Allow declaring "shared resources" for direct child nodes via the new
@ResourceLock(target = CHILDREN)attribute.Using the
@ResourceLock(target = CHILDREN)in a class-level annotation has the same semantics as adding an annotation with the samevalueandmodeto each test method and nested test class declared in this class.This may improve parallelization when a test class declares a
READlock, but only a few methods hold aREAD_WRITElock.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations