fix windows build#4
Closed
fcakyon wants to merge 2 commits into
Closed
Conversation
fcakyon
commented
Feb 13, 2021
fcakyon
commented
- currently, this package cannot be instlalled on windows due to gcc flags in setup.py
- this pr fixes this bug so that the package can be installed on windows
- refer to this commit
Owner
|
Would this change break installation on Linux? |
Author
|
@junjuew No it doesnt affect linux installation. It will make this package cross platform. You can try it yourself on linux by: |
Author
|
@junjuew would you mind accepting the pr and release a new version on pypi? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.