feat(auth): bump jsonwebtoken-icp to v10.3.0#2675
Open
peterpeterparker wants to merge 14 commits intomainfrom
Open
feat(auth): bump jsonwebtoken-icp to v10.3.0#2675peterpeterparker wants to merge 14 commits intomainfrom
peterpeterparker wants to merge 14 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
jsonwebtoken has fixed
val.validate_nbf = true;in v10.3.0 (see CHANGELOG). As a result, many tests were failing because the nbf was provided but, invalid. It's worth to note that the crate ignores validating nbf is provided as none. In other words, if provided, it should be valid, if not provided, no check. That's why the fix concern only the test.Reference: https://github.com/Keats/jsonwebtoken/blob/master/src/validation.rs#L61
That said, in the API I was not setting nbf for the GitHub auth token. So for consistency I added it in https://github.com/junobuild/api/releases/tag/v0.0.3