Add copy_to_globals request

[brichet]

This PR adds a new request to copy a variable to the global scope, and tests on the feature.

It's a draft PR until microsoft/debugpy#1147 is released.

[JohanMabille]

I think storing a boolean stating if the copy_to_globals_request is available might be more efficient (you perform the comparison only once during the initialization of the debugger).

[brichet]

OK, I thought we could keep it generic for future changes.

[JohanMabille]

A good idea here would be to replace the . characters in m_debug_py with spaces, to ease future comparisons:

auto debugpy_version = version.cast<std::string>();
std::replace(debugpy_version.begin(), debugpy_version.end(), '.' , ' ');

You can then initialize the boolean member by calling a comparison function with debugpy_version and the minimal version of debugpy in the same format (i.e. "1 6 5");

[brichet]

I don't see the difference if we replace '.' with ' '.
Can it simplify the comparison ?

EDIT: related to the use of istream_iterator in next comment ?

[JohanMabille]

Yes because we can then use the istream_iterator as a tokenizer (it skips the spaces in a string by default, see the implementation in the comment below).

[JohanMabille]

If we assume that version1 and version2 have the format "MAJOR MINOR PATCH", then the implementation of this function can be improved:

using iterator_type = std::istream_iterator<int>;
std::istringstream iv1(version1), iv2(version2);
return std::lexicographical_compare(
    iterator_type(iv1),
    iterator_type(),
    iterator_type(iv2),
    iterator_type()
);

[brichet]

Thanks @JohanMabille.
Not sure we can assume it as users can still have alpha/beta versions I thinks.

[JohanMabille]

In that case we need to split the string to remove the alpha / beta part.

[brichet]

OK, let's do it this way

[JohanMabille]

I think that m_copy_to_globals_available would be more explicit, the fact that it is available after version 1.6.5 only is an implementation detail.

[brichet]

right, thanks.

[JohanMabille]

find_first_pos returns an unsigned int, so this should be size_t pos = ... . Then pos must be compared to std::string::npos: if (pos != std::string::npos) ...

[brichet]

Thanks, I first tried it but I was comparing it to -1 and the compiler was not OK 😄

[JohanMabille]

Thanks!