Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something to note:
When I was first attempting this I added a persistence key which attempts to persist the canvas in localstorage. Using the
htmlproperty for initializing the webview means that the origin is null which causes indexeddb to throw an error and tldraw to force a reload. Another consequence of usinghtmlto initialize is that if the page reloads you end up with an empty page. I've got a PR in Wry to add aload_htmlmethod so that the html can be re-initialized after a reload. I'll also eventually wire upwith_navigation_handlerso users can prevent redirects if they want.Anyway, this is a huge milestone!