Potential type error at `normalizeOptions(...)`

[yfwz100]

See:

BrowserFS/src/core/FS.ts

Lines 79 to 87 in bef1dc0

	function normalizeOptions(options: any, defEnc: string | null, defFlag: string, defMode: number | null): {encoding: string; flag: string; mode: number} {
	switch (typeof options) {
	case 'object':
	return {
	encoding: typeof options['encoding'] !== 'undefined' ? options['encoding'] : defEnc,
	flag: typeof options['flag'] !== 'undefined' ? options['flag'] : defFlag,
	mode: normalizeMode(options['mode'], defMode!)
	};
	case 'string':

If options in normalizeOptions(...) is null, typeof options equals "object" and the following code will throw a TypeError:

BrowserFS/src/core/FS.ts

Line 83 in bef1dc0

encoding: typeof options['encoding'] !== 'undefined' ? options['encoding'] : defEnc,

[yfwz100]

I found that #206 is a PR to this issue...

[yfwz100]

The upstream has updated the docs:

https://github.com/DefinitelyTyped/DefinitelyTyped/blob/81d0e4984d4b5e10668020eacd4b9a4542c5c837/types/node/index.d.ts#L4029

fs.readFile() accepts null as parameters for options.

[jvilk]

Yes; BrowserFS needs to be updated to track a specific version of the node FS API. It has gotten a bit out of sync. At the same time, I'm not happy with some of the code surrounding how BrowserFS emulates the Node API; it might be easier to simply repackage Node's JS modules and implement its internal bindings.

This is something I would like to revisit soon. However, I'm currently a bit busy preparing for a move across the country and finishing my PhD.

[yfwz100]

👍