Feature/keyword index#42
Conversation
jya-dev
left a comment
jya-dev
left a comment
There was a problem hiding this comment.
Thank you for using my tool and helping me improve.
I wrote a review comment. I would appreciate it if you could consider correcting it.
| c = canvas.Canvas(buf, pagesize=self.pagesize) | ||
| keywords = self.note.get_keywords() | ||
| for n, img in enumerate(imglist): | ||
| print('Page: '+str(n)) |
There was a problem hiding this comment.
It is good to suppress debug output.
There was a problem hiding this comment.
Hi @jya-dev , Thanks for feedback - Debug output has been suppressed
| found.append(keyword) | ||
| for i in found: | ||
| try: | ||
| print('Added Keyword: '+i.get_keyword()+' Keyword Page: '+str(i.get_page_number())) |
There was a problem hiding this comment.
It is good to suppress debug output.
There was a problem hiding this comment.
Hi @jya-dev , Thanks for feedback - Debug output has been suppressed
| c.setTitle('Notes') | ||
| c.setSubject('Notes') | ||
| c.setAuthor('Author') |
There was a problem hiding this comment.
I think these lines are unnecessary.
There was a problem hiding this comment.
Hi @jya-dev , Thanks for feedback - It has been removed
| parser_convert.add_argument('--exclude-background', action='store_true', default=False, help='exclude background and make it transparent (PNG and SVG are supported)') | ||
| parser_convert.add_argument('--pdf-type', choices=['original', 'vector'], default='original', help='select PDF conversion type') | ||
| parser_convert.add_argument('--no-link', action='store_true', default=False, help='disable links in PDF') | ||
| parser_convert.add_argument('--no-keyword', action='store_true', default=False, help='disable keywords in PDF') |
There was a problem hiding this comment.
I'd like to set annotation feature disable by default
because annotation icons hide handwriting on Supernote tablets and make it hard to read.
This feature is useful on PC, but I would like to prioritize usability on Supernote tablets.
…been disabled by default\n3. It has been removed unnecessary parts of code"
|
Hi @jya-dev , Thanks for feedback - Keyword Annotation feature has been disabled by default |
2 participants
Added keywords created in supernote tablet to newly generated pdf as annotations. Tested on Chauvet 2.15.29 version.
Please, let me know if you have any questions or suggestions to improve the code. Its was written under specific use case so source code might be not efficient