Small tweaks to improve Durvo diagram scaling with high-TDS data#18
Open
Benito7349 wants to merge 2 commits into
Open
Small tweaks to improve Durvo diagram scaling with high-TDS data#18Benito7349 wants to merge 2 commits into
Benito7349 wants to merge 2 commits into
Conversation
Owner
|
Hi, thank you so much for your contribution and for the clear explanation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I’m a geologist with some programming background, and I’m currently working with water samples from deep wells
(over 1,400 feet deep). These samples have very high TDS concentrations, and I’ve run into scaling issues when
using the Durvo diagram.
🧩 Summary
This pull request introduces a few adjustments to the function used for generating the Durvo diagram.
The main goal is to improve the handling of scaling issues when working with water samples that have very
high TDS concentrations, such as those from deep wells (>1400 ft).
⚙️ Changes
Modified the function to better handle samples with high TDS values.
Improved axis scaling to prevent data overlap.
(Temporary workaround) Exporting to .svg and adjusting elements manually in Inkscape to fix legend overlap.
🐞 Known Issue
The legend still overlaps the diagram in some cases. I haven’t found a robust solution for this yet,
but exporting to .svg and rearranging elements manually in Inkscape works as a workaround.
🙏 Acknowledgments
Many thanks for developing this tool — it’s been extremely helpful in my work.
I hope these small changes can be useful to others facing similar challenges.