fix(helm): set KAGENT_CONTROLLER_NAME to support custom release names #1195
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing kagent with a custom Helm release name (e.g., `helm install my-kagent ...`), agents failed to connect to the controller because KAGENT_URL was hardcoded to `kagent-controller`. The GetControllerName() function in go/internal/utils/common.go looks for the KAGENT_CONTROLLER_NAME environment variable, but it was never set in the Helm chart, causing it to fall back to the hardcoded default. This fix adds KAGENT_CONTROLLER_NAME to the controller ConfigMap, using the Helm fullname template to match the actual service name. Fixes kagent-dev#1193 Signed-off-by: Azeez Syed <syedazeez337@gmail.com>
syedazeez337
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When installing kagent with a custom Helm release name (e.g.,
helm install my-kagent ...), agents failed to connect to the controller becauseKAGENT_URLwas hardcoded tokagent-controller.Root cause: The
GetControllerName()function ingo/internal/utils/common.golooks for theKAGENT_CONTROLLER_NAMEenvironment variable, but it was never set in the Helm chart, causing it to fall back to the hardcoded defaultkagent-controller.Fix: Add
KAGENT_CONTROLLER_NAMEto the controller ConfigMap using the Helm fullname template to match the actual service name.Test Plan
my-kagent)KAGENT_CONTROLLER_NAMEwas missing from ConfigMap before fixKAGENT_CONTROLLER_NAME=my-kagent-controllerin ConfigMap after upgradeFixes #1193