Skip to content

Conversation

@onematchfox
Copy link
Contributor

Not exactly sure what the process is here - so feel free to let me know if I've missed anything. Mostly interested in the a2a-sdk update, as v0.3.1 contains a fix I put through to resolve context cancellation issues that have been plaguing me when testing multi-agent workflows. I did scan the release notes of both projects for breaking changes, and I don't think any of them affected this project's usage of the libraries. Ran the default set of agents locally, and everything seems to work fine.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Copilot AI review requested due to automatic review settings August 27, 2025 07:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates two dependency versions in the kagent-adk package: google-adk from >=1.8.0 to >=1.11.0 and a2a-sdk from >=0.2.16 to >=0.3.1. The primary motivation is to incorporate a fix in a2a-sdk v0.3.1 that resolves context cancellation issues in multi-agent workflows.

Key changes:

  • Updated google-adk minimum version requirement to 1.11.0
  • Updated a2a-sdk minimum version requirement to 0.3.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@EItanya
Copy link
Contributor

EItanya commented Aug 27, 2025

I have been holding off doing/testing this because of this issue: trpc-group/trpc-a2a-go#78. But if it works it works 🤷 😆 . In general we need to move away from that library because we really don't need 99% of what it's doing in kagent

I'm gonna do some testing on this myself to see what happens.

@EItanya EItanya merged commit 0e9ebba into kagent-dev:main Aug 27, 2025
14 of 15 checks passed
@onematchfox onematchfox deleted the adk-upgrade branch August 27, 2025 15:38
yanivmn pushed a commit to yanivmn/kagent that referenced this pull request Aug 28, 2025
)

Not exactly sure what the process is here - so feel free to let me know
if I've missed anything. Mostly interested in the `a2a-sdk` update, as
[`v0.3.1`](https://github.com/a2aproject/a2a-python/releases/tag/v0.3.1)
contains [a fix](a2aproject/a2a-python#383) I
put through to resolve context cancellation issues that have been
plaguing me when testing multi-agent workflows. I did scan the release
notes of both projects for breaking changes, and I don't think any of
them affected this project's usage of the libraries. Ran the default set
of agents locally, and everything seems to work fine.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
EItanya pushed a commit that referenced this pull request Sep 3, 2025
Addresses issue whereby agent->agent calls are currently failing with
errors like this in the UI:


``` json
{"id":"call_xx": "name": "transfor_to_agent", "response":{"result": null}}
```

Agent pods show the following errors:
```
ERROR:google_adk.google.adk.agents.remote_a2a_agent:Failed to resolve remote A2A agent kagent__NS__my_agent: Failed to resolve AgentCard from URL http://my-agent.kagent:8080/: HTTP Error 405: Failed to fetch agent card from http://my-agent.kagent:8080/: Client error '405 Method Not Allowed' for url 'http://my-agent.kagent:8080/'
For more information check: https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/405
```

I guess this was my bad, and it's related to the upgrade in #816.

Signed-off-by: Brian Fox <878612+onematchfox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants