Skip to content

Clarify analytics dashboard 404 fallback error #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kali113 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clarify analytics dashboard 404 fallback error #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion web/src/lib/analytics/dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,13 @@ async function parseError(response: Response): Promise<{
.json()
.catch(() => null)) as ErrorPayload | null;

const fallbackMessage =
response.status === 404
? "Analytics endpoint not found (404). Deploy the latest API and verify VITE_BACKEND_URL."
: "Analytics request failed";

return {
message: parsed?.error?.message || "Analytics request failed",
message: parsed?.error?.message || fallbackMessage,
Comment on lines +64 to +70
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds new 404-specific fallback messaging but the behavior isn’t covered by tests. Since the web repo already has Vitest unit tests for similar $lib network/client utilities, consider adding a small unit test for parseError (or fetchAnalyticsDashboard) verifying that a 404 with a non-JSON body produces the new fallback message while non-404 statuses keep the existing fallback.

Copilot uses AI. Check for mistakes.
code: parsed?.error?.type,
};
}
Expand Down
Loading