feat: add stagehand#4
Merged
Merged
Conversation
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced May 5, 2026
kalil0321
added a commit
that referenced
this pull request
May 5, 2026
…-version Knocks out items #3, #4, #9 of the agent-friendliness backlog (#62). Schema version stays at 1 since the contract has not shipped to prod — fields are added in place rather than bumping versions. Item #3 — Stable `usage` subset Different SDKs (Claude / OpenCode / Copilot) emit different keys for the same concepts (cache_creation_input_tokens vs cache_write_tokens, estimated_cost_usd vs total_cost vs total_cost_usd, etc). New helper `_normalize_usage()` maps SDK-native keys into a stable subset {input_tokens, output_tokens, cache_read_tokens, cache_write_tokens, total_cost_usd} and parks the SDK-native dict under `usage.raw` for power users. Wrappers can rely on the top-level keys without breaking when the user switches SDK. Item #4 — Machine-readable `error_kind` Previously agents had to pattern-match on prose like "[Errno 13] Permission denied: '/x'" to decide whether to retry / abort / surface to the user. New `error_kind` field on every `agent --json` and `engineer --json` payload, with a fixed enum: misuse | config_invalid | permission_denied | network | engine_failure | interrupted | unknown Inferred via `_classify_error()` which uses isinstance checks on exceptions (KeyboardInterrupt, PermissionError, ConnectionError, TimeoutError) and substring fallback on plain messages. Misuse paths now pass `error_kind_hint="misuse"` explicitly. Item #9 — `--json-schema-version` Top-level `reverse-api-engineer --json-schema-version` prints the schema version (currently `1`) and exits 0. Lets a wrapper query the contract version without having to invoke a real run. Bonus: KeyboardInterrupt now formats as the literal "interrupted" in the `error` field (str(KeyboardInterrupt()) is empty); empty exception messages fall back to the class name. Tests: 9 new tests in test_cli_followups.py (TestSchemaV2Normalization, TestJsonSchemaVersionFlag) + updated existing tests to assert on the normalized usage shape and the new error_kind field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
kalil0321
added a commit
that referenced
this pull request
May 6, 2026
…-version Knocks out items #3, #4, #9 of the agent-friendliness backlog (#62). Schema version stays at 1 since the contract has not shipped to prod — fields are added in place rather than bumping versions. Item #3 — Stable `usage` subset Different SDKs (Claude / OpenCode / Copilot) emit different keys for the same concepts (cache_creation_input_tokens vs cache_write_tokens, estimated_cost_usd vs total_cost vs total_cost_usd, etc). New helper `_normalize_usage()` maps SDK-native keys into a stable subset {input_tokens, output_tokens, cache_read_tokens, cache_write_tokens, total_cost_usd} and parks the SDK-native dict under `usage.raw` for power users. Wrappers can rely on the top-level keys without breaking when the user switches SDK. Item #4 — Machine-readable `error_kind` Previously agents had to pattern-match on prose like "[Errno 13] Permission denied: '/x'" to decide whether to retry / abort / surface to the user. New `error_kind` field on every `agent --json` and `engineer --json` payload, with a fixed enum: misuse | config_invalid | permission_denied | network | engine_failure | interrupted | unknown Inferred via `_classify_error()` which uses isinstance checks on exceptions (KeyboardInterrupt, PermissionError, ConnectionError, TimeoutError) and substring fallback on plain messages. Misuse paths now pass `error_kind_hint="misuse"` explicitly. Item #9 — `--json-schema-version` Top-level `reverse-api-engineer --json-schema-version` prints the schema version (currently `1`) and exits 0. Lets a wrapper query the contract version without having to invoke a real run. Bonus: KeyboardInterrupt now formats as the literal "interrupted" in the `error` field (str(KeyboardInterrupt()) is empty); empty exception messages fall back to the class name. Tests: 9 new tests in test_cli_followups.py (TestSchemaV2Normalization, TestJsonSchemaVersionFlag) + updated existing tests to assert on the normalized usage shape and the new error_kind field. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.