Fix/external logs#7
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
@greptile |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR removes external library logging noise and fixes hardcoded version strings. The main changes include:
browser-useby replacing complexMemoryLogHandlerwith direct logger configurationclaude_agent_sdkinengineer.pyandutils.py__version__imports acrossbrowser.py,opencode_ui.pyThe refactoring significantly simplifies the codebase by removing ~70 lines of complex log handler code in favor of straightforward logger suppression. The changes are well-focused on the stated goal of removing external logs.
Confidence Score: 4/5
MemoryLogHandlerwith simpler suppression logic is a good refactor. Minor concerns include redundantsuppress_browser_use_logs()calls and potential environment variable timing issues, but these don't affect correctness.Important Files Changed
__version__import, added environment variable for browser-use logging, and improved result display formatting__version__instead of hardcoded version string