Skip to content

No PRs shown after adding plugin (Fix #21) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karlingen wants to merge 1 commit into
base: main
Choose a base branch
from
Open

No PRs shown after adding plugin (Fix #21) #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Samples/ActivePullRequests/PullRequestsListingPageContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,12 @@ class PullRequestsListingPageContent extends React.Component<IPullRequestsListin
// Extract and send users, waiting for dropdowns to populate and user filter preselections to complete
await this.extractAndSendUsersAsync(pullRequests);

// Apply persisted repository filters, which will trigger onFilterChanged and update filteredItems.
// At this point all user filters are already preselected by the parent.
// Loading state will be set to false after filters are applied.
// Apply persisted filters (if any), then ensure filteredItems is populated.
// onFilterChanged may already have been triggered by setFilterItemState inside
// filterByPersistedRepositories, but for fresh installs with no persisted filters
// it won't fire, so we call it explicitly to guarantee filteredItems is set.
await this.props.filterByPersistedRepositories();
this.onFilterChanged();

if (this._isMounted) {
this.setState({ loading: false });
Expand All @@ -168,6 +170,7 @@ class PullRequestsListingPageContent extends React.Component<IPullRequestsListin
this.setState({ loading: false, currentUserId: currentUser.id });
}
}

}

componentDidUpdate(prevProps: Readonly<IPullRequestsListingPageContentProps>, prevState: Readonly<IPullRequestsListingPageContentState>, snapshot?: any): void {
Expand Down