Skip to content
This repository was archived by the owner on Aug 31, 2022. It is now read-only.

Conversation

@marsmining
Copy link

rm spec issues re Object.create(null) & proto

the previous code used the idiom of Object.create(null) to use an object like a hash or cache, and leveraged the prototype chain as a type of cache miss failover. there is some js spec weirdness and changes around node 0.12 surrounding the existence of __proto__ when using Object.create(null).

to eliminate this confusion i've added a function to replace the above so that the semantics are clear and consistent and we aren't using the non-standard __proto__.

also update npm dev deps to latest versions and added a missing jshintrc.

the previous code used the idiom of `Object.create(null)` to use an object
like a hash or cache, and leveraged the prototype chain as a type of cache
miss failover. there is some js spec wierdness and changes around node 0.12
surrounding the existence of `__proto__` when using `Object.create(null)`.

to eliminate this confusion i've added a function to replace the above so
that the semantics are clear and consistent and we aren't using the
non-standard `__proto__`.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@marsmining
Copy link
Author

I signed it!

On Thu, Jun 18, 2015 at 10:45 AM, googlebot notifications@github.com
wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#22 (comment)
.

Brandon van Beekum
Konradinstraße 24, Berlin 12105
Cell: +49 0151 1029 4688

@googlebot
Copy link

CLAs look good, thanks!

turn autowatch off, add karma-firefox-launcher to dev deps.
@moderndegree
Copy link

+1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants