Add support for consensus parameters override #751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderofstuff
requested changes
Nov 6, 2025
Collaborator
coderofstuff
left a comment
coderofstuff
left a comment
There was a problem hiding this comment.
Please document how to use this. Maybe via:
- Add a new file in docs for how to use it (docs/override-params.md)
- Update README.md to have a reference to override-params.md
coderofstuff
previously approved these changes
Nov 10, 2025
Collaborator
coderofstuff
left a comment
coderofstuff
left a comment
There was a problem hiding this comment.
Approved with suggestions.
| conn_builder = conn_builder.with_mem_budget(rocksdb_mem_budget); | ||
| } | ||
|
|
||
| if let Some(output_path) = args.override_params_output { |
Collaborator
There was a problem hiding this comment.
It's worth documenting this usage in override-params.md - that you can construct a starter JSON through simpa
Contributor
Author
There was a problem hiding this comment.
It's already there, in the last section
README.md
Outdated
| </details> | ||
| </details> | ||
|
|
||
| ## Override consensus parameters |
Collaborator
There was a problem hiding this comment.
Can you add this documentation as a section below Logging?
Also add update the text slightly to: "You can experiment with non-standard consensus parameters in non-mainnet environments by supplying..." (I know that's mentioned in the override-params.md, but I think it's also worth mentioning here.)
coderofstuff
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to support changing consensus constants for test purposes, without editing the code and recompiling.