logging: Redirect yamux warnings/errors to logger#289
logging: Redirect yamux warnings/errors to logger#289sboeuf merged 1 commit intokata-containers:masterfrom
Conversation
|
/cc @grahamwhaley. Related: kata-containers/proxy#89. |
Capture yamux messages to the logger. Fixes kata-containers#288. Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
jodh-intel
force-pushed
the
add-yamux-logging
branch
from
7f9acef to
bce5f78
Compare
|
lgtm, but I presume it might hit the same issue as the proxy equiv. |
|
The proxy issue was caused by a bad test which was leaking resources. These tests pass for me so let's see what restarting the failing CI jobs does... |
|
lgtm I guess CI is failing because of 9p patch was not applied |
|
LGTM! CI is still failing though...
@devimc Are we not using prebuilt kata guest kernel binaries? |
|
@bergwolf we are, but seem like the patch was not applied in obs |
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
==========================================
- Coverage 43.25% 43.24% -0.02%
==========================================
Files 14 14
Lines 2240 2155 -85
==========================================
- Hits 969 932 -37
+ Misses 1140 1107 -33
+ Partials 131 116 -15
Continue to review full report at Codecov.
|
6 participants
Capture yamux messages to the logger.
Fixes #288.
Signed-off-by: James O. D. Hunt james.o.hunt@intel.com