This repository was archived by the owner on May 12, 2021. It is now read-only.
agent: sync system clock with hwclock when creating new sandbox#423
Closed
bergwolf wants to merge 1 commit into
Closed
agent: sync system clock with hwclock when creating new sandbox#423bergwolf wants to merge 1 commit into
bergwolf wants to merge 1 commit into
Conversation
Member
Author
|
/cc @linxiulei This should be able to fix kata-containers/runtime#951 |
|
|
||
| func (s *sandbox) syncTimeHw2Sys() error { | ||
| cmd := &exec.Cmd{ | ||
| Path: "/sbin/hwclock", |
Contributor
There was a problem hiding this comment.
heh - do we know we have this in all our rootfs distro variants btw?
Member
Author
There was a problem hiding this comment.
oh, yeah, you are right, I'm missing the osbuilder PR! Will send it out soon.
Member
Author
There was a problem hiding this comment.
Sent github.com/kata-containers/osbuilder/pull/213 and updated the Depends-on tag here. Thanks for catching it so quickly!
The two might differ due to vm templating. We need to fix the drift by setting system clock from hardware clock since kvmclock should be trusted. Depends-on: github.com/kata-containers/packaging#260 Depends-on: github.com/kata-containers/osbuilder#213 Fixes: kata-containers#422 Signed-off-by: Peng Tao <bergwolf@gmail.com>
Member
Author
|
replaced by #425 since it would work for all architectures and hypervisors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two might differ due to vm templating. We need to fix the
drift by setting system clock from hardware clock since kvmclock
should be trusted.
Depends-on: github.com/kata-containers/packaging#260
Depends-on: github.com/kata-containers/osbuilder#213
Fixes: #422
Signed-off-by: Peng Tao bergwolf@gmail.com