This repository was archived by the owner on May 12, 2021. It is now read-only.
make: Add build option STATIC=1 to statically link#523
Merged
Conversation
Member
Author
|
/test |
Member
Author
|
This PR doesn't change the default behavior of kata-agent. jenkins-ci-Power8-ubuntu-16-04-initrd failed: jenkins-ci-fedora failed: |
devimc
reviewed
Apr 8, 2019
| endif | ||
| # go build common flags | ||
| BUILDFLAGS := -buildmode=pie | ||
| ifndef STATIC |
There was a problem hiding this comment.
maybe you should change this condition, I think the following would be easier to understand
ifdef STATIC
LDFLAGS := -extldflags '-static'
else
BUILDFLAGS := -buildmode=pie
endif
Member
Author
There was a problem hiding this comment.
maybe you should change this condition, I think the following would be easier to understand
ifdef STATIC LDFLAGS := -extldflags '-static' else BUILDFLAGS := -buildmode=pie endif
Updated.
Member
Author
|
/test |
bergwolf
approved these changes
Apr 9, 2019
devimc
approved these changes
Apr 9, 2019
|
/retest |
Add build option STATIC=1 to statically link kata-agent. Fixes: kata-containers#522 Signed-off-by: Hui Zhu <teawater@hyper.sh>
Member
Author
|
/test |
Member
Author
|
jenkins-ci-Power8-ubuntu-16-04-initrd fail: This PR doesn't change the default behavior of kata-agent. |
Contributor
|
@nitkon ^^^ can you have a check of the power8 CI slave status? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build option STATIC=1 to statically link kata-agent.
Fixes: #522
Signed-off-by: Hui Zhu teawater@hyper.sh