Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

action: Improve porting checks#844

Merged
devimc merged 1 commit into
kata-containers:masterfrom
jodh-intel:action-improve-porting-checks
Oct 1, 2020
Merged

action: Improve porting checks#844
devimc merged 1 commit into
kata-containers:masterfrom
jodh-intel:action-improve-porting-checks

Conversation

@jodh-intel
Copy link
Copy Markdown

@jodh-intel jodh-intel commented Sep 14, 2020

Improve the PR porting GitHub action by referencing a central script to
handle the checks rather than hard-coding them in the workflow YAML.

This ensures all PRs use the latest porting policy encoded in the
script and makes maintenance easier.

Related: kata-containers/kata-containers#634

Fixes: #843.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

Improve the PR porting GitHub action by referencing a central script to
handle the checks rather than hard-coding them in the workflow YAML.

This ensures all PRs use the latest porting policy encoded in the
script and makes maintenance easier.

Related: kata-containers/kata-containers#634

Fixes: kata-containers#843.

Signed-off-by: James O. D. Hunt <james.o.hunt@intel.com>
@jodh-intel
Copy link
Copy Markdown
Author

/test

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 14, 2020

Codecov Report

Merging #844 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
+ Coverage   60.08%   60.15%   +0.07%     
==========================================
  Files          17       17              
  Lines        2668     2668              
==========================================
+ Hits         1603     1605       +2     
+ Misses        902      901       -1     
+ Partials      163      162       -1     

Copy link
Copy Markdown
Member

@fidencio fidencio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jodh-intel
Copy link
Copy Markdown
Author

/test-ubuntu

@jodh-intel jodh-intel added no-backport-needed Changed do not need to be applied to an older branch / repository no-forward-port-needed Changed do not need to be applied to a newer branch / repository labels Sep 15, 2020
@jodh-intel
Copy link
Copy Markdown
Author

/test

@jodh-intel
Copy link
Copy Markdown
Author

Ping @kata-containers/agent - a very quick PR to review and hopefully ack so we can get the last of these PRs landed...

@jodh-intel
Copy link
Copy Markdown
Author

This PR needs 1 more ack... today would be great folks!

@devimc devimc merged commit 70ea18e into kata-containers:master Oct 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-backport-needed Changed do not need to be applied to an older branch / repository no-forward-port-needed Changed do not need to be applied to a newer branch / repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

action: Improve porting checks

3 participants