This repository was archived by the owner on May 12, 2021. It is now read-only.
use-cases: Add documentation for using Nvidia GPU with Kata#615
Merged
Conversation
Jimmy-Xu
force-pushed
the
add-nvidia-gpu-use-case
branch
2 times, most recently
from
6c5ec93 to
4553780
Compare
Contributor
grahamwhaley
left a comment
grahamwhaley
left a comment
There was a problem hiding this comment.
@Jimmy-Xu - nice! thanks for putting this together!
Some stylistic feedback left.
Better pull in some nvidia folks to assess technical detail.
Jimmy-Xu
force-pushed
the
add-nvidia-gpu-use-case
branch
2 times, most recently
from
6ecc021 to
4a05bdb
Compare
Member
|
@Jimmy-Xu Thanks for adding this. |
Jimmy-Xu
force-pushed
the
add-nvidia-gpu-use-case
branch
from
4a05bdb to
4b7dbbc
Compare
jodh-intel
reviewed
Mar 17, 2020
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
Hi @Jimmy-Xu - thanks for raising this!
I've only read through very quickly so need to do a follow-on review, but I have some general comments:
- You need to add a "Fixes: #XXX" comment in the commit
(see https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format) - Technical terms: some of the "non-word" terms in this document (such as "Nvidia" ;) are not recognised by our spell-checker. I suggest running it manually and then raising a PR to add the (very small number of) new terms.
(See: https://github.com/kata-containers/tests/tree/master/cmd/check-spelling#spell-check-a-document-file and https://github.com/kata-containers/tests/tree/master/cmd/check-spelling#update-the-word-list-fragment). - Once a term is introduced, we need to be consistent with its use (so "Nvidia", not "NVIDIA").
This document decsribes how an Nvidia GPU can be used with Kata Containers in Nvidia GPU pass-through mode. Fixes kata-containers#616 Signed-off-by: Jimmy Xu <junming.xjm@antfin.com>
Jimmy-Xu
force-pushed
the
add-nvidia-gpu-use-case
branch
from
4b7dbbc to
d0768d5
Compare
Jimmy-Xu
force-pushed
the
add-nvidia-gpu-use-case
branch
2 times, most recently
from
952685b to
a2895c0
Compare
|
Hey that's a super cool PR! I'll try to take a stab at it during the week :D |
jodh-intel
reviewed
Mar 18, 2020
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
Thanks @Jimmy-Xu - this is looking good!
Jimmy-Xu
force-pushed
the
add-nvidia-gpu-use-case
branch
from
a2895c0 to
c5bddc3
Compare
- Index the use-case of Intel and Nvidia GPUs - Fix link to vfio-mediated-device in Intel GPU use-cases Fixes kata-containers#616 Signed-off-by: Jimmy Xu <junming.xjm@antfin.com>
Jimmy-Xu
force-pushed
the
add-nvidia-gpu-use-case
branch
from
c5bddc3 to
16197d6
Compare
jodh-intel
approved these changes
Mar 18, 2020
Jimmy-Xu
changed the title
Related: kata-containers/packaging#938 Fixes kata-containers#616 Signed-off-by: Jimmy Xu <junming.xjm@antfin.com>
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This document decsribes how an Nvidia GPU can be used with Kata Containers in Nvidia GPU Pass-Through mode.
fix issue: #616
related Issue: #517
blocked onkata-containers/packaging#938related PR: