This repository was archived by the owner on May 12, 2021. It is now read-only.
clh: Pull static binary when possible.#1141
Closed
jcvenegas wants to merge 1 commit into
Closed
Conversation
Cloud hypervisor publish its own static binaries on releases. Lets try to pull from it when possible, else build from source, this is useful when for some reason clh build is broken. Fixes: kata-containers#1140 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Member
|
I'd like to mention that this a good practice that should be used for every single binary we consume! |
Member
Author
|
/test |
likebreath
approved these changes
Sep 2, 2020
Contributor
likebreath
left a comment
likebreath
left a comment
There was a problem hiding this comment.
lgtm. @egernst Would you please give it a try (in the runtime repo w/ depends-on should work)?
egernst
added a commit
to egernst/runtime
that referenced
this pull request
Sep 2, 2020
Just a demo PR. Unfortunately the 0.7 branch for CLH is now missing a reference on a dependency; let's bump to 0.8.0. Depends-on: kata-containers/packaging#1141 Fixes: kata-containers#2926 Signed-off-by: Eric Ernst <eric.g.ernst@gmail.com>
egernst
added a commit
to egernst/runtime
that referenced
this pull request
Sep 2, 2020
Just a demo PR. Unfortunately the 0.7 branch for CLH is now missing a reference on a dependency; let's bump to 0.8.0. Depends-on: github.com/kata-containers/packaging#1141 Fixes: kata-containers#2926 Signed-off-by: Eric Ernst <eric.g.ernst@gmail.com>
jcvenegas
added a commit
to jcvenegas/runtime
that referenced
this pull request
Sep 3, 2020
Fixes: #1 Depends-on: github.com/kata-containers/packaging#1141 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jodh-intel
approved these changes
Sep 7, 2020
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
Thanks @jcvenegas.
lgtm
This needs to be ported to 2.0 fwics.
Also, seeing this change inspired: #1143.
|
Branch conflicted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud hypervisor publish its own static binaries on releases. Lets try
to pull from it when possible, else build from source, this is useful
when for some reason clh build is broken.
Fixes: #1140
Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com