This repository was archived by the owner on May 12, 2021. It is now read-only.
kernel: disable pci shpc hotplug for arm64#498
Merged
Conversation
jodh-intel
approved these changes
May 9, 2019
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
lgtm
@grahamwhaley, @ganeshmaharaj - this option is also set for x86_64 so we'd better double-check if it should be.
Contributor
|
@devimc for input around bus rescanning pci and stuff I think.... |
Contributor
Author
|
As far as I know, x86 use ACPI to do pci device hotplug, so it will no this issue I think. |
|
/test |
devimc
approved these changes
May 9, 2019
jongwu
added a commit
to jongwu/packaging
that referenced
this pull request
May 10, 2019
As shpchp used for pci hotplug on arm64 initialized its bottom half work as a delay work for 5 seconds, pci bus rescan triggered between up half and bottom half of shpc interrupt handling will fail. so disable shpc and let bus rescan to do the device hotplug on arm64. Fixes: kata-containers#498 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Contributor
Author
|
@devimc help retest, thank you. |
|
@jongwu - here you go... /retest |
As shpchp used for pci hotplug on arm64 initialized its bottom half work as a delay work for 5 seconds, pci bus rescan triggered between up half and bottom half of shpc interrupt handling will fail. so disable shpc and let bus rescan to do the device hotplug on arm64. Fixes: kata-containers#498 Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Contributor
Author
|
@jodh-intel need retest, thank you! |
|
/test |
Pennyzct
added a commit
to Pennyzct/packaging
that referenced
this pull request
Apr 9, 2020
Since we disable pci shpc hotplug for arm64, see kata-containers#498 for detailed reason. We need to move CONFIG_HOTPLUG_PCI_SHPC from common conf to x86_64-specific. Fixes: kata-containers#1004 Signed-off-by: Penny Zheng <penny.zheng@arm.com> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Pennyzct
added a commit
to Pennyzct/packaging
that referenced
this pull request
Apr 15, 2020
Since we disable pci shpc hotplug for arm64, see kata-containers#498 for detailed reason. We need to move CONFIG_HOTPLUG_PCI_SHPC from common conf to x86_64-specific. Fixes: kata-containers#1004 Signed-off-by: Penny Zheng <penny.zheng@arm.com> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Pennyzct
added a commit
to Pennyzct/packaging
that referenced
this pull request
Apr 17, 2020
Since we disable pci shpc hotplug for arm64, see kata-containers#498 for detailed reason. We need to move CONFIG_HOTPLUG_PCI_SHPC from common conf to x86_64-specific. Fixes: kata-containers#1004 Signed-off-by: Penny Zheng <penny.zheng@arm.com> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Pennyzct
added a commit
to Pennyzct/packaging
that referenced
this pull request
Apr 21, 2020
Since we disable pci shpc hotplug for arm64, see kata-containers#498 for detailed reason. We need to move CONFIG_HOTPLUG_PCI_SHPC from common conf to x86_64-specific. Fixes: kata-containers#1004 Signed-off-by: Penny Zheng <penny.zheng@arm.com> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shpchp used for pci hotplug on arm64 initialized
its bottom half work as a delay work for 5 seconds, pci bus
rescan triggered between up half and bottom half of shpc interrupt
handling will fail. so disable shpc and let bus rescan
to do the device hotplug on arm64.
Fixes: #499
Signed-off-by: Jianyong Wu jianyong.wu@arm.com
@jodh-intel @Pennyzct @bergwolf @grahamwhaley