ci: Enable check VERSION among the components without the runtime

[GabyCT]

The main purpose is that this script will be used to verify
that VERSION among the components are equal before merging the runtime.

Fixes #613

Depends-on: github.com/kata-containers/runtime#1858

Signed-off-by: Gabriela Cervantes gabriela.cervantes.tellez@intel.com

[jcvenegas]

Instead of do this could you try.

check_versions $(cat "${GOPATH}/src/${runtime_repo}/VERSION")
...
#$1 Version to check to branches merged
check_versions() {
version_to_check=${1:-}
if version_to_check == "";then
info query the version from latest runtime in branch ${branch}
else
    kata_version=${version_to_check}
fi
...
for repo in "${repos[@]}"; do
  if repo == kata-runtime; then
      not checking runtime because we want the rest of repos are in $version_to_check
      continue
  fi
}

[grahamwhaley]

yep - let's do a specific check or some smart way to 'build up' the list of repos to check, and not add the runtime to the list in the first place if we are doing the pre-check.

[grahamwhaley]

':-' idiom to set only if not set maybe?

[grahamwhaley]

yep - let's do a specific check or some smart way to 'build up' the list of repos to check, and not add the runtime to the list in the first place if we are doing the pre-check.

[grahamwhaley]

I think/guess this is reply on the runtime repo having been already checked out to the correct PR - as this script will be called for by the runtime repo code on a runtime repo PR being checked.... maybe a small comment to note that - otherwise it could be a little confusing :-)

[GabyCT]

@jcvenegas changes applied

[jcvenegas]

Thanks gaby a few additional comments.

[jcvenegas]

Almost there, I wonder if instead of assume that the runtime repo exist here, could you read the version as a second parameter?
so in travis you can do something like
tag_repos.sh pre-release $(cat VERSION)
this also helps to remove the GOPATH variable and runtime_repo

• Also could you add some usage info ?
• finally you can add some basic test here tag_repos_test.sh
  tag_repos.sh pre-release 100000 will fail
  or
  tag_repos.sh pre-release $(curl https://github.com/kata-containers/runtime/blob/master/VERSION) I think should work

[GabyCT]

@jcvenegas changes applied

[jcvenegas]

/test

[jcvenegas]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).