This repository was archived by the owner on May 12, 2021. It is now read-only.
pkg: Add bash completion#63
Merged
jcvenegas merged 1 commit intokata-containers:masterfrom Jun 15, 2018
Merged
Conversation
Fixes kata-containers#59 Signed-off-by: Ricardo Aravena <raravena@branch.io>
|
Thanks @raravena80! lgtm |
Member
|
Thank you ! lgtm |
Member
|
due to #72 I tested manually, I got the following errors: |
Member
Author
|
@jcvenegas I was curious on how the files from |
Member
|
@raravena80 your changes should work, I am trying again now. |
Member
|
@raravena80 I see, the packaging scripts currently point to create packages based in kata1.0 the bash-completition was added after the release. |
jcvenegas
pushed a commit
that referenced
this pull request
Jul 2, 2019
rootfs-builder: Refactor rootfs.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
These are the bits for bash completion in the packaging repo.
Pending kata-containers/runtime#378