lint: Switch golang linter to golangci-lint

[ganeshmaharaj]

gometalinter is deprecated and will be archived April '19. The
suggestion is to switch to golangci-lint which is apparently 5x faster
than gometalinter.

Partially fixes: github.com/kata-containers/runtime#1377

[ganeshmaharaj]

@grahamwhaley the build error says the node was unavailable https://zuul.opendev.org/t/kata-containers/builds?pipeline=PR-check&change=155 Is there a way we can make this check optional?

[grahamwhaley]

Hi @ganeshmaharaj - the check is a WIP (we tend to use the proxy repo for such WIPs, as it is generally the least active repo ;-) ). The check is not marked as 'required', so we can still merge without a real administrator 'force' - just ignore the results of the PR-check for now. See #154 (comment) for more details.
Hey, if you want to help fix that.... then the zuul config repo for kata is over at https://git.openstack.org/cgit/kata-containers/zuul-config/tree/ ;-)

[ganeshmaharaj]

@grahamwhaley gotcha. yes should be able to look at things, once i am done with some of the things that i am doing.

[ganeshmaharaj]

/test

[ganeshmaharaj]

@devimc @chavafg should we ignore the failures here too? they all seem to fit the pattern of the builds that we know have a history of failures.

[chavafg]

There was a network timeout and a timeout building a docker image... have sent rebuild.
Power8 and metrics are unstable right now.

[grahamwhaley]

as you know, I'd like to see what the error was that is being fixed, but, given I believe you did the right thing ;-)
lgtm
I've re-nudged the 18.04-initrd CI, as that should not fail, but I suspect it is spurious and unrelated to this PR - we can probably ignore it if it fails again (given many of the other CIs are quite happy with this change).

[ganeshmaharaj]

can this patch be merged?