Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

hypervisor cleanup#1023

Closed
egernst wants to merge 2 commits into
kata-containers:masterfrom
egernst:fc-prereqs
Closed

hypervisor cleanup#1023
egernst wants to merge 2 commits into
kata-containers:masterfrom
egernst:fc-prereqs

Conversation

@egernst
Copy link
Copy Markdown
Member

@egernst egernst commented Dec 14, 2018

No description provided.

Eric Ernst added 2 commits December 13, 2018 16:51
vc: capabilities: add capability flags for 9p and hotplug
1b307db 
Not all hypervisors support 9p. Not all hypervisors support hotplug. Add
capability flags to track this.  Since most hypervisor implementations
in Kata *do* support these, the set semantices are reversed (ie, set the
flag if you do not support the feature).

Fixes: kata-containers#1022

Signed-off-by: Eric Ernst <eric.ernst@intel.com>
vc: common hypervisor variable move out of qemu impl
43ee1c8 
operation type lived in qemu before - appears this should be part of
hypervisor.go, since this isn't specific to qemu, and would be used by
other hypervisors as well.

Signed-off-by: Eric Ernst <eric.ernst@intel.com>
@egernst
Copy link
Copy Markdown
Member Author

egernst commented Dec 14, 2018 •
edited
Loading

@sboeuf @mcastelino @amshinde @bergwolf - PTAL

@egernst egernst changed the title Fc prereqs hypervisor cleanup Dec 14, 2018
@egernst
Copy link
Copy Markdown
Member Author

egernst commented Dec 14, 2018

/test

@jodh-intel
Copy link
Copy Markdown

jodh-intel commented Dec 14, 2018

Hi @egernst - our static analysis scripts are saying what I was about to:

virtcontainers/capabilities.go:11:2:warning: const hotplugUnsupported is unused (U1000) (unused)
virtcontainers/capabilities.go:12:2:warning: const plan9FSUnsupported is unused (U1000) (unused)
virtcontainers/capabilities.go:41:27:warning: func (*capabilities).isHotplugSupported is unused (U1000) (unused)
virtcontainers/capabilities.go:48:27:warning: func (*capabilities).setHotplugUnsupported is unused (U1000) (unused)
virtcontainers/capabilities.go:52:27:warning: func (*capabilities).is9pSupported is unused (U1000) (unused)
virtcontainers/capabilities.go:59:27:warning: func (*capabilities).set9pUnsupported is unused (U1000) (unused)

Either we wait until these functions are actually needed, or how about reworking virtcontainers/mock_hypervisor.go as it seems reasonable for that hypervisor to support neither hotplug nor 9p? That might merit a bit of light unit-test reworking possibly.

@devimc
Copy link
Copy Markdown

devimc commented Dec 17, 2018

@egernst any update?, I need this change to copy file from host to guest

@devimc
Copy link
Copy Markdown

devimc commented Dec 17, 2018

@egernst @jodh-intel I'm including these patches here #1041

@egernst egernst closed this Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@egernst @jodh-intel @devimc