This repository was archived by the owner on May 12, 2021. It is now read-only.
config: Add firecracker as a supported hypervisor configuration#1043
Merged
Conversation
Author
|
This relies on the introduction of FC as a hypervisor implementation of virtcontainers. |
Author
|
/test |
Author
|
Depends on #1044 |
Author
|
@mcastelino PR updated. |
jodh-intel
approved these changes
Dec 19, 2018
jodh-intel
left a comment
jodh-intel
left a comment
There was a problem hiding this comment.
lgtm
I wonder if it's worth also updating configuration.toml.in to add the firecracker stanza (but commented out)?
| } | ||
|
|
||
| func newQemuHypervisorConfig(h hypervisor) (vc.HypervisorConfig, error) { | ||
| func newFirecrackerHypervisorConfig(h hypervisor) (vc.HypervisorConfig, error) { |
There was a problem hiding this comment.
Nit: Adding the firecracker function above the existing one make reviewing this change harder ;(
Member
There was a problem hiding this comment.
Ah, I did it alphabetical order. noted.
Author
|
Depends on #1044 |
In order to let the user choose firecracker hypervisor instead of QEMU (from the configuration.toml), let's add it to the list of supported hypervisors. Fixes kata-containers#1042 Depends-on: github.com/kata-containers#1044 Signed-off-by: Eric Ernst <eric.ernst@intel.com>
By breaking down updateRuntimeConfig() into smaller functions, this commit prevents the function to grow a Go complexity higher than 15. Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Author
|
/test |
Contributor
|
LGTM |
egernst
approved these changes
Dec 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.