Unit test: fix bugs on a few unit tests on aarch64 by Pennyzct · Pull Request #1202 · kata-containers/runtime

Pennyzct · 2019-01-31T08:51:12Z

Description of problem

09:55:00 cli/kata-check_arm64.go:129:9:warning: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (golint)
09:55:02 virtcontainers/qemu_arm64_test.go:43:23:warning: unused variable or constant undeclared name: virt (varcheck)
09:55:02 virtcontainers/qemu_arm64_test.go:50:11:warning: unused variable or constant undeclared name: defaultMemSlots (varcheck)
09:55:02 virtcontainers/qemu_arm64_test.go:54:40:warning: unused variable or constant too few arguments in call to arm64.memoryTopology (varcheck)
09:55:02 virtcontainers/qemu_arm64_test.go:29:23:warning: unused variable or constant undeclared name: virt (varcheck)
09:55:02 cli/kata-check_test.go:141:113:warning: unused variable or constant undeclared name: TestDataa (varcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:43:23:warning: unused struct field undeclared name: virt (structcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:50:11:warning: unused struct field undeclared name: defaultMemSlots (structcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:54:40:warning: unused struct field too few arguments in call to arm64.memoryTopology (structcheck)
09:55:03 virtcontainers/qemu_arm64_test.go:29:23:warning: unused struct field undeclared name: virt (structcheck)
09:55:03 cli/kata-check_test.go:141:113:warning: unused struct field undeclared name: TestDataa (structcheck)
09:55:03 cli/kata-check_test.go:141:113:warning: undeclared name: TestDataa (unused)
09:55:04 cli/kata-check_test.go:141:113:warning: undeclared name: TestDataa (staticcheck)
09:55:05 Build step 'Execute shell' marked build as failure

There existed some bugs on a few unit tests on aarch64, and I will fix them one by one.

jodh-intel · 2019-01-31T09:15:02Z

Hi @Pennyzct - The ppc64le-specific Travis build is still complaining about a couple of issues:

virtcontainers/hypervisor_test.go:440:6:warning: type testNestedVMMData is unused (U1000) (unused)
virtcontainers/hypervisor_test.go:446:6:warning: func genericTestRunningOnVMM is unused (U1000) (unused)

Pennyzct · 2019-01-31T10:03:25Z

Hi~ @jodh-intel I'm kind of confused. Those generic* functions are like a template for all arch. you can choose to use or do your own arch-specific implementation, just like func genericMemoryTopology. I didn't do the work for ppc64le, but it share the same logic with aarch64. That is, it also couldn't use the genericTestRunningOnVMM and need to implement its own function.

jodh-intel · 2019-01-31T10:08:12Z

Hi @Pennyzct - it confused me a bit. Maybe @nitkon could tal?

raravena80 · 2019-02-05T20:24:00Z

@Pennyzct @nitkon ping, any updates? Thx!

Pennyzct · 2019-02-11T10:50:43Z

/retest

Pennyzct · 2019-02-11T11:30:44Z

Hi~ @jodh-intel @grahamwhaley @sameo Do we need to put // nolint: varcheck,unused, // nolint: unused on all generic var and function?
All existing PR including #1218, #1223 are trying to fix the unused statis error, and here, the travis-ci failing is also because that newly implemented generic var testNestedVMMData and function genericTestRunningOnVMM is not used in ppc64le.

Pennyzct · 2019-02-13T02:50:18Z

/retest

Pennyzct · 2019-02-13T07:31:57Z

/retest

Pennyzct · 2019-02-13T08:25:08Z

/retest

Pennyzct · 2019-02-13T10:03:40Z

Hi~ @jodh-intel @grahamwhaley @sameo @teawater all former static check errors haven been eliminated.
For now, it stuck here.

17:15:07 === RUN   TestCreateEmptySandbox
17:15:07 time="2019-02-13T17:15:06+08:00" level=error msg="Create new sandbox failed" error="Missing kernel path" sandbox=7f49d00d-1995-4156-8c79-5f5ab24ce138 sandboxid=7f49d00d-1995-4156-8c79-5f5ab24ce138 source=virtcontainers subsystem=sandbox
17:15:07 time="2019-02-13T17:15:06+08:00" level=error msg="Create new sandbox failed" error="Missing kernel path" sandbox=7f49d00d-1995-4156-8c79-5f5ab24ce138 sandboxid=7f49d00d-1995-4156-8c79-5f5ab24ce138 source=virtcontainers subsystem=sandbox
17:15:07 time="2019-02-13T17:15:07+08:00" level=error msg="failed to start proxy" error="Invalid proxy parameters {id:foobar path: agentURL: consoleURL: logger:0x40007c86e0 debug:false}" params="{foobar    0x40007c86e0 false}" proxy type=invalidProxyType source=virtcontainers vm=foobar
17:15:07 FAIL	github.com/kata-containers/runtime/virtcontainers	4.690s

I will /retest to see if it reproduces itself.

Pennyzct · 2019-02-14T01:45:02Z

/retest

…o file argument struct TestDataa in generic func genericTestGetCPUDetails is repeatedly defined in almost all arch-dependent .go file, cli/kata-check_amd64_test.go, cli/kata-check_ppc64le_test.go, etcm, except arm64. let's only declare it once in cli/kata-check_test.go. change its name to testCPUDetail for better understanding. Fixes: kata-containers#1200 Signed-off-by: Penny Zheng <penny.zheng@arm.com>

refine a set of test functions under qemu_arm64_test.go. e.g. test func for memoryTopology shouldn't be the same one on amd64, since for now, we don't support nvdimm on arm64. Fixes: kata-containers#1200 Signed-off-by: Penny Zheng <penny.zheng@arm.com>

Pennyzct · 2019-02-14T04:18:59Z

/retest

original tests for func RunningOnVMM are sort of amd64-specific, since all other archs don't support nested VMM for now. Fixes: kata-containers#1200 Signed-off-by: Penny Zheng <penny.zheng@arm.com>

since generic func genericAppendBridges and genericBridges is also applied for machine type QemuVirt, we use it as implementation for appendBridges and bridges on aarch64. since const defaultPCBridgeBus is used in generic func genericAppendBridges for pc machine, we should define it once in generic file, instead of redefining it in different arch-specific files. Fixes: kata-containers#1200 Signed-off-by: Penny Zheng <penny.zheng@arm.com>

since all generic* could bring unused linter warnings, which lead to CI crash, we add nolint comment to avoid them. Fixes: kata-containers#1200 Signed-off-by: Samuel Ortiz <sameo@linux.intel.com> Signed-off-by: Penny Zheng <penny.zheng@arm.com>

Pennyzct · 2019-02-14T07:13:29Z

/retest

refine struct testData in func TestGetCPUDetails to remove redundant /unused struct field expectedVendor and expectedModel Fixes: kata-containers#1200 Signed-off-by: Penny Zheng <penny.zheng@arm.com>

Pennyzct · 2019-02-14T07:15:35Z

/retest

Pennyzct · 2019-02-14T08:46:53Z

Hi~ @jodh-intel @grahamwhaley @sameo finally, i got almost all green on this PR, especially, ARM CI has entirely passed all tests. ;). ptal.

chavafg · 2019-02-14T19:31:27Z

I see that the vsock job failed 2 times on the cpu hot-plug tests, but your changes seem unrelated:

Summarizing 2 Failures:

[Fail] Hot plug CPUs container with CPU period and quota [It] should have 3 CPUs 
/tmp/jenkins/workspace/kata-containers-runtime-fedora-vsocks-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:89

[Fail] Hot plug CPUs container with CPU constraint [It] should have 2 CPUs 
/tmp/jenkins/workspace/kata-containers-runtime-fedora-vsocks-PR/go/src/github.com/kata-containers/tests/integration/docker/cpu_test.go:108

Ran 225 of 234 Specs in 2520.438 seconds
FAIL! -- 223 Passed | 2 Failed | 0 Pending | 9 Skipped --- FAIL: TestIntegration (2547.13s)
FAIL

http://jenkins.katacontainers.io/job/kata-containers-runtime-fedora-vsocks-PR/217/consoleText
http://jenkins.katacontainers.io/job/kata-containers-runtime-fedora-vsocks-PR/218/console

Any idea @devimc

Pennyzct · 2019-02-15T05:11:41Z

Hi~ I get all green here.;). Could anyone give it a review? thanks a lot! @jodh-intel @grahamwhaley @sameo @chavafg @devimc

grahamwhaley

nice set of fixes.
I see @sameo SoB on at least one of the patches, so I'd like to see his ack here.

Pennyzct · 2019-02-15T10:15:43Z

one commit unit-test: add nolint comment to avoid unused warning is inspired by his commit virtcontainers: Tag unused functions and routines for ARM64 on #1218, so i hope to add his @sameo SOB. ;)

sameo

LGTM

Pennyzct force-pushed the unit-test branch from 2d4773f to c6e6166 Compare January 31, 2019 08:52

Pennyzct mentioned this pull request Feb 1, 2019

ppc64le: Fix hotplug issue #1186

Merged

This was referenced Feb 7, 2019

Fix ARM CI #1218

Closed

ARM: get the ARM CIs up kata-containers/ci#30

Closed

jenkins-ci-ARM-ubuntu-18-04 always fail #1206

Closed

sameo mentioned this pull request Feb 11, 2019

arm64: Fix static check error #1223

Closed

This was referenced Feb 11, 2019

Makefile: Set ARCH in GOPATH not set mode #1225

Merged

VMCache: the new function that creates VMs as caches before using it #1166

Merged

Pennyzct force-pushed the unit-test branch 2 times, most recently from 487ea1c to 389495a Compare February 13, 2019 02:45

Pennyzct force-pushed the unit-test branch 2 times, most recently from e670203 to 70a719a Compare February 13, 2019 07:24

Pennyzct force-pushed the unit-test branch from 70a719a to 1941486 Compare February 13, 2019 08:24

Pennyzct added 2 commits February 14, 2019 11:34

Pennyzct force-pushed the unit-test branch from 1941486 to b7436b0 Compare February 14, 2019 03:34

Pennyzct added 2 commits February 14, 2019 14:56

unit-test: test func for RunningOnVMM should be arch-dependent

e93fb0b

original tests for func RunningOnVMM are sort of amd64-specific, since all other archs don't support nested VMM for now. Fixes: kata-containers#1200 Signed-off-by: Penny Zheng <penny.zheng@arm.com>

Pennyzct force-pushed the unit-test branch from b7436b0 to 0185d45 Compare February 14, 2019 07:04

unit-test: refine func TestGetCPUDetails

23c554e

refine struct testData in func TestGetCPUDetails to remove redundant /unused struct field expectedVendor and expectedModel Fixes: kata-containers#1200 Signed-off-by: Penny Zheng <penny.zheng@arm.com>

Pennyzct force-pushed the unit-test branch from 0185d45 to 23c554e Compare February 14, 2019 07:15

grahamwhaley requested a review from sameo February 15, 2019 10:05

grahamwhaley approved these changes Feb 15, 2019

View reviewed changes

sameo approved these changes Feb 15, 2019

View reviewed changes

grahamwhaley merged commit 816ea42 into kata-containers:master Feb 15, 2019

egernst mentioned this pull request Feb 26, 2019

Stable 1.5.1 rc #1281

Merged

Conversation

Pennyzct commented Jan 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of problem

Uh oh!

jodh-intel commented Jan 31, 2019

Uh oh!

Pennyzct commented Jan 31, 2019

Uh oh!

jodh-intel commented Jan 31, 2019

Uh oh!

raravena80 commented Feb 5, 2019

Uh oh!

Pennyzct commented Feb 11, 2019

Uh oh!

Pennyzct commented Feb 11, 2019

Uh oh!

Pennyzct commented Feb 13, 2019

Uh oh!

Pennyzct commented Feb 13, 2019

Uh oh!

Pennyzct commented Feb 13, 2019

Uh oh!

Pennyzct commented Feb 13, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pennyzct commented Feb 14, 2019

Uh oh!

Pennyzct commented Feb 14, 2019

Uh oh!

Pennyzct commented Feb 14, 2019

Uh oh!

Pennyzct commented Feb 14, 2019

Uh oh!

Pennyzct commented Feb 14, 2019

Uh oh!

chavafg commented Feb 14, 2019

Uh oh!

Pennyzct commented Feb 15, 2019

Uh oh!

grahamwhaley left a comment

Choose a reason for hiding this comment

Uh oh!

Pennyzct commented Feb 15, 2019

Uh oh!

sameo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Pennyzct commented Jan 31, 2019 •

edited

Loading

Pennyzct commented Feb 13, 2019 •

edited

Loading