This repository was archived by the owner on May 12, 2021. It is now read-only.
VMCache: check if vm_cache_endpoint file exists before VMCache server…#1410
Merged
Merged
Conversation
76f3d65 to
421f576
Compare
Member
Author
|
/test |
devimc
reviewed
Mar 22, 2019
421f576 to
f14b5fe
Compare
Member
Author
|
/test |
devimc
approved these changes
Mar 27, 2019
Member
Author
|
jenkins-ci-ARM-ubuntu-18-04 failed: This a64 format issue is handled by #1433 |
bergwolf
reviewed
Apr 2, 2019
| } | ||
| if err = unix.Unlink(path); err != nil && !os.IsNotExist(err) { | ||
| return nil, err | ||
| if _, err = os.Stat(path); err == nil || os.IsExist(err) { |
Member
There was a problem hiding this comment.
There is no os.IsExist error for os.Stat.
Member
Author
There was a problem hiding this comment.
There is no
os.IsExisterror foros.Stat.
Submit a new version according to your comments.
… runs There is an issue that more than one VMCache server can run with same vm_cache_endpoint file together. The cause is factory try to remove vm_cache_endpoint file before VMCache server runs. Change it to check if vm_cache_endpoint file exists before VMCache server runs to handle the issue. Fixes: kata-containers#1385 Signed-off-by: Hui Zhu <teawater@hyper.sh>
f14b5fe to
b6f382e
Compare
Member
Author
|
/test |
bergwolf
approved these changes
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… runs
There is an issue that more than one VMCache server can run with same
vm_cache_endpoint file together.
The cause is factory try to remove vm_cache_endpoint file before VMCache
server runs.
Change it to check if vm_cache_endpoint file exists before VMCache server
runs to handle the issue.
Fixes: #1385
Signed-off-by: Hui Zhu teawater@hyper.sh