This repository was archived by the owner on May 12, 2021. It is now read-only.
[test][DNM]Move sandbox cgroup from pause to parent#1522
Closed
jcvenegas wants to merge 3 commits into
Closed
Conversation
If a sandbox contaienr is created lets use its cgroupath and use the parent to create kata sandbox cgroup. Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
The hypervisor will be limited at sandbox cgroup level. Fixes: kata-containers#1430 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
jcvenegas
force-pushed
the
sandbox-cgroup
branch
from
29a85c6 to
6aae88c
Compare
Member
Author
|
/test |
Based in sandbox cgroup path. Create a new cgroup . Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Member
Author
|
/test |
mcastelino
reviewed
Apr 16, 2019
Contributor
mcastelino
left a comment
mcastelino
left a comment
There was a problem hiding this comment.
@jcvenegas where is the code that eliminates the creation of the container and pause cgroups? Should that also be part of this PR?
|
@jcvenegas - any update? Branch is conflicted. Is this PR still required? |
Member
|
@jcvenegas any updates? Thx |
Member
|
ping @jcvenegas |
Member
|
Ping @jcvenegas |
|
Branch is conflicted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the sandbox container cgroup and get its parent to create
kata-sandboxcgroup. This cgroup is going to be where kata components will be placed (qemu, proxy, etc).In the case of a Kuberentes the pod will inherent the kubepod properties for cpus and cpusets. Memory cgroup is still handled as a special case where is not restricted.