This repository was archived by the owner on May 12, 2021. It is now read-only.
fix ut failure due to incorrect cleanup and make it runnable with non-root#1526
Merged
Conversation
Member
bergwolf
commented
Apr 12, 2019
bergwolf
commented
- fix ut failure as cleanup removes the initial test setup, as stated in ut failures due to incorrect test cleanup #1525
- make ut runnable with non-root
We should allow UT to run without root. Signed-off-by: Peng Tao <bergwolf@hyper.sh>
cleanup() actually removes all things under testdir and causes UT failures. === RUN TestCreateMockSandbox ERRO[0000] Create new sandbox failed error="QEMU path (/tmp/vc-tmp-007004370/hypervisor) does not exist" sandbox=7f49d00d-1995-4156-8c79-5f5ab24ce138 sandboxid=7f49d00d-1995-4156-8c79-5f5ab24ce138 source=virtcontainers subsystem=sandbox exit status 1 Fixes: kata-containers#1525 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Member
|
/test |
devimc
approved these changes
Apr 12, 2019
amshinde
approved these changes
Apr 12, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.