This repository was archived by the owner on May 12, 2021. It is now read-only.
shimv2 should return grpc error codes#1528
Merged
Merged
Conversation
So that shimv2 can convert it into grpc errors. Signed-off-by: Peng Tao <bergwolf@hyper.sh>
containerd checks for the grpc error code to determine correct recover action upon grpc errors. We need to provide them properly. Unfortunately ttrpc doesn't support grpc interceptor so we have to modify every service function for it. Fixes: kata-containers#1527 Signed-off-by: Peng Tao <bergwolf@hyper.sh>
So that caller can determine that it is ENOENT-alike error. Signed-off-by: Peng Tao <bergwolf@hyper.sh>
Member
Author
|
/test |
|
cc @lifupan |
teawater
approved these changes
Apr 13, 2019
lifupan
approved these changes
Apr 15, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
containerd relies on it to determine proper actions, e.g., fail the operation or wait for an exit event.[1]
ref: [1] https://github.com/containerd/cri/blob/master/pkg/server/container_stop.go#L141