This repository was archived by the owner on May 12, 2021. It is now read-only.
shim v2: fix set status when container exit#1601
Merged
lifupan merged 1 commit intokata-containers:masterfrom May 1, 2019
Ace-Tang:exit_status
Merged
shim v2: fix set status when container exit#1601lifupan merged 1 commit intokata-containers:masterfrom Ace-Tang:exit_status
lifupan merged 1 commit intokata-containers:masterfrom
Ace-Tang:exit_status
Conversation
in wait function, should send msg to exit channel after task status has updated, since shim.Wait() is running in another goroutine, when it receive msg from exit channel, it will stop waiting and return, then someone who hold this Wait() get return, it can delete task, if exit msg is send first, the container status may still be running. Fixes: #1600 Signed-off-by: Ace-Tang <aceapril@126.com>
Member
|
/test |
lifupan
approved these changes
Apr 30, 2019
Contributor
Author
|
Fail with Seems not releated to the PR, do someone see this fails before |
Member
I just restart the failed tests. |
devimc
approved these changes
Apr 30, 2019
sboeuf
approved these changes
Apr 30, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in wait function, should send msg to exit channel after task status has
updated, since shim.Wait() is running in another goroutine, when it
receive msg from exit channel, it will stop waiting and return, then
someone who hold this Wait() get return, it can delete task, if exit msg
is send first, the container status may still be running.
Fixes: #1600
Signed-off-by: Ace-Tang aceapril@126.com