Networking: Ensure that network namespace is propagated#1665
Networking: Ensure that network namespace is propagated#1665jodh-intel merged 1 commit intokata-containers:masterfrom
Conversation
Network namespace needs to be propagated if available at createSandbox() Fixes: kata-containers#1664 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
| shmSize: sandboxConfig.ShmSize, | ||
| sharePidNs: sandboxConfig.SharePidNs, | ||
| stateful: sandboxConfig.Stateful, | ||
| networkNS: NetworkNamespace{NetNsPath: sandboxConfig.NetworkConfig.NetNSPath}, |
There was a problem hiding this comment.
@mcastelino Looking at your description of the issue #1664 there are actually 2 ways to fix this. The network config is stored inside sandbox.config.NetworkConfig, so you could find the same information from the config.
But this patch looks good to me too :)
There was a problem hiding this comment.
The two are the same, -- sandbox.config is sandboxConfig as assigned above.
There was a problem hiding this comment.
@sboeuf yes the information is available within the store, and that is what I ended up doing. However it is wrong for us to pass in an empty value when there is a value present. So either we need to remove that parameter and always retrieve if from config or set it up properly.
|
/test |
| shmSize: sandboxConfig.ShmSize, | ||
| sharePidNs: sandboxConfig.SharePidNs, | ||
| stateful: sandboxConfig.Stateful, | ||
| networkNS: NetworkNamespace{NetNsPath: sandboxConfig.NetworkConfig.NetNSPath}, |
There was a problem hiding this comment.
The two are the same, -- sandbox.config is sandboxConfig as assigned above.
|
/retest |
|
Also when debugging this I find create sandbox being called multiple times during the course of the container creation. This is a bit unexpected. Hopefully the traces will indicate why. |
|
/test |
|
Re-test - now that kernel issue is fixed |
|
Merging as the sles CI is dead... |
7 participants
Network namespace needs to be propagated if available at
createSandbox()
Fixes: #1664
Signed-off-by: Manohar Castelino manohar.r.castelino@intel.com