This repository was archived by the owner on May 12, 2021. It is now read-only.
shim v2: Close vhostfd after vm get vhostfd#1670
Merged
lifupan merged 1 commit intokata-containers:masterfrom May 21, 2019
Merged
shim v2: Close vhostfd after vm get vhostfd#1670lifupan merged 1 commit intokata-containers:masterfrom
lifupan merged 1 commit intokata-containers:masterfrom
Conversation
|
/test |
|
cc @amshinde |
jodh-intel
reviewed
May 13, 2019
xs3c
force-pushed
the
fix-vfio-hang
branch
2 times, most recently
from
4098830 to
01f1646
Compare
|
Ahh, but the CI caught a small problem: That's arguably a bug with our commit checker but the solution is simple: change the "shim v2:" prefix to "shim-v2:" I think ;) |
Member
|
/test @xs3c - I ammended your commit header to make travis happy (to me, that static failure was lame, so I wanted to make your life easier). Thx - LGTM. |
egernst
approved these changes
May 13, 2019
lifupan
approved these changes
May 14, 2019
Member
|
Hi @xs3c , it seems you didn't do gofmt to the files you changed, that's why the CI failed. |
Contributor
Author
Contributor
Author
|
/test |
1 similar comment
Member
|
/test |
Member
|
still looks good, restarting what appears to be a flaky test failure on Ubuntu 18.04. |
If kata containers is using vfio and vhost net，the unbinding of vfio would be hang. In the scenario, vhost net kernel thread takes a reference to the qemu's mm, and the reference also includes the mmap regions on the vfio device file. so vhost kernel thread would be not released when qemu is killed as the vhost file descriptor still is opened by shim v2 process, and the vfio device is not released because there's still a reference to the mmap. Fixes: kata-containers#1669 Signed-off-by: Yang, Wei <w90p710@gmail.com> Signed-off-by: Eric Ernst <eric.ernst@intel.com>
bergwolf
approved these changes
May 16, 2019
Member
|
/test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If kata containers is using vfio and vhost net，the unbinding
of vfio would be hang. In the scenario, vhost net kernel thread
takes a reference to the qemu's mm, and the reference also includes
the mmap regions on the vfio device file. so vhost kernel thread
would be not released when qemu is killed as the vhost file
descriptor still is opened by shim v2 process, and the vfio device
is not released because there's still a reference to the mmap.
Fixes: #1669
Signed-off-by: Yang, Wei w90p710@gmail.com