Conversation
egernst
commented
May 15, 2019
egernst
commented
- include nemu configuration adjustments
- network namespace propagation fix
Network namespace needs to be propagated if available at createSandbox() Fixes: kata-containers#1664 Signed-off-by: Manohar Castelino <manohar.r.castelino@intel.com>
- For initial offering of virtiofsd, hugepages are required - use the qemu hypervisor type for configuration template - decrease virtiofs cache size from 8192 to 1024, to better support running with virtio-fs on smaller machines while hugepages are required. - For initial experimental release, utilize virtio-serial instead of vsock Fixes: kata-containers#1662 Signed-off-by: Eric Ernst <eric.ernst@intel.com>
mcastelino
left a comment
mcastelino
left a comment
There was a problem hiding this comment.
LGTM
But I feel we should add support for #1657 for virtiofsd.
If not our density will go down with virtiofsd.
| DEFSHAREDFS := virtio-9p | ||
| DEFSHAREDFS_NEMU := virtio-fs | ||
| DEFVIRTIOFSDAEMON := $(VIRTIOFSDBINDIR)/virtiofsd | ||
| DEFVIRTIOFSDAEMON := $(VIRTIOFSDBINDIR)/virtiofsd-x86_64 |
There was a problem hiding this comment.
@ganeshmaharaj @egernst did we not add support for file backed non huge page for virtiofsd.
Do you plan to add that as a subsequent PR
There was a problem hiding this comment.
I wish we had that now, but it isn't ready yet for 1.7. TBH, I'm not sure if this would be a fair candidate for stable releases of 1.7, but definitely will enhance the usability. Perhaps since this is an experimental feature...
There was a problem hiding this comment.
Yup. That is the next thing in our pipe. Given this feature is experimental and also the fact that file backend seems to have too many criterion to satisfy, it might be better to run it through rigorous testing before we land it.
|
/test |
4 participants
