Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

versions: Update golang to 1.11.10#1694

Merged
bergwolf merged 1 commit intokata-containers:masterfrom
marcov:bump-go-version
May 17, 2019
Merged

versions: Update golang to 1.11.10#1694
bergwolf merged 1 commit intokata-containers:masterfrom
marcov:bump-go-version

Conversation

@marcov
Copy link
Contributor

@marcov marcov commented May 16, 2019

Set the minimum golang version to 1.11.10, the latest stable 1.11 version
at the time of writing. Go 1.11 is required to build the agent with working
vsock support.

Fixes: #1693

Signed-off-by: Marco Vedovati mvedovati@suse.com

Set the minimum golang version to 1.11.10, the latest stable 1.11 version
at the time of writing. Go 1.11 is required to build the agent with working
vsock support.

Fixes: kata-containers#1693

Signed-off-by: Marco Vedovati <mvedovati@suse.com>
@marcov
Copy link
Contributor Author

marcov commented May 16, 2019

cc @jodh-intel @bergwolf

/test

Copy link
Member

@bergwolf bergwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcov !

Copy link

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jodh-intel
Copy link

Restarted 18.04 CI which failed with:

[1] • Failure [41.886 seconds]
[1] docker exec
[1] /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/exec_test.go:19
[1]   modifying a container with exec
[1]   /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/exec_test.go:39
[1]     should have the changes [It]
[1]     /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/exec_test.go:40
[1] 
[1]     Expected
[1]         <string>: 
[1]     not to be empty
[1] 
[1]     /tmp/jenkins/workspace/kata-containers-runtime-ubuntu-18-04-PR/go/src/github.com/kata-containers/tests/integration/docker/exec_test.go:48

@jodh-intel
Copy link

Restarted metrics CI which failed with the following (brutally summarised to avoid upsetting @grahamwhaley :)...

18:25:35 java.io.EOFException

@grahamwhaley
Copy link
Contributor

More useful is to note what actually failed, not the way that Jenkins java based slave agent reports the death:

18:25:35 Install kata containers dependencies
18:25:35 FATAL: command execution failed
18:25:35 java.io.EOFException

@jodh-intel
Copy link

@grahamwhaley - my default stance would have been to log more context, yes :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump min golang version to 1.11

5 participants