Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

versions: Update docker to 19.03#1715

Closed
chavafg wants to merge 1 commit intokata-containers:masterfrom
chavafg:topic/update-docker
Closed

versions: Update docker to 19.03#1715
chavafg wants to merge 1 commit intokata-containers:masterfrom
chavafg:topic/update-docker

Conversation

@chavafg
Copy link
Contributor

@chavafg chavafg commented May 21, 2019

Move our supported docker version to 18.09.
This is the latest stable and the only supported for Fedora 29,
which we are going to use soon for our CI as Fedora 28 is EOL
at the end of the month. In addition docker 18.09 is the
one that our documentation says that we support.

Fixes: #1110.

Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com

grahamwhaley
grahamwhaley approved these changes May 21, 2019
View reviewed changes
Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grahamwhaley
Copy link
Contributor

grahamwhaley commented May 21, 2019

/test

devimc
devimc approved these changes May 21, 2019
View reviewed changes
Copy link

@devimc devimc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like the CI is broken, nothing related to this pr

@chavafg chavafg force-pushed the topic/update-docker branch 2 times, most recently from 19d894c to 5ac47c8 Compare May 21, 2019 21:24
@chavafg
Copy link
Contributor Author

chavafg commented May 22, 2019

/test

@chavafg chavafg force-pushed the topic/update-docker branch from 5ac47c8 to db9660f Compare May 23, 2019 20:00
@GabyCT
Copy link
Contributor

GabyCT commented May 27, 2019

/test

2 similar comments
@amshinde
Copy link
Member

amshinde commented Jun 3, 2019

/test

@egernst
Copy link
Member

egernst commented Jun 12, 2019

/test

zklei pushed a commit to zklei/runtime that referenced this pull request Jun 13, 2019
@bergwolf
vendor: update grpc-go dependency
cd03e0c 
This updates grpc-go vendor package to v1.11.3 release, to fix server.Stop()
handling so that server.Serve() does not wait blindly.

Full commit list:
d11072e (tag: v1.11.3) Change version to 1.11.3
d06e756 clientconn: add support for unix network in DialContext. (kata-containers#1883)
452c2a7 Change version to 1.11.3-dev
d89cded (tag: v1.11.2) Change version to 1.11.2
98ac976 server: add grpc.Method function for extracting method from context (kata-containers#1961)
0f5fa28 Change version to 1.11.2-dev
1e2570b (tag: v1.11.1) Change version to 1.11.1
d28faca client: Fix race when using both client-side default CallOptions and per-call CallOptions (kata-containers#1948)
48b7669 Change version to 1.11.1-dev
afc05b9 (tag: v1.11.0) Change version to 1.11.0
f2620c3 resolver: keep full unparsed target string if scheme in parsed target is not registered (kata-containers#1943)
9d2250f status: rename Status to GRPCStatus to avoid name conflicts (kata-containers#1944)
2756956 status: Allow external packages to produce status-compatible errors (kata-containers#1927)
0ff1b76 routeguide: reimplement distance calculation
dfbefc6 service reflection can lookup enum, enum val, oneof, and field symbols (kata-containers#1910)
32d9ffa Documentation: Fix broken link in rpc-errors.md (kata-containers#1935)
d5126f9 Correct Go 1.6 support policy (kata-containers#1934)
5415d18 Add documentation and example of adding details to errors (kata-containers#1915)
57640c0 Allow storing alternate transport.ServerStream implementations in context (kata-containers#1904)
031ee13 Fix Test: Update the deadline since small deadlines are prone to flakes on Travis. (kata-containers#1932)
2249df6 gzip: Add ability to set compression level (kata-containers#1891)
8124abf credentials/alts: Remove the enable_untrusted_alts flag (kata-containers#1931)
b96718f metadata: Fix bug where AppendToOutgoingContext could modify another context's metadata (kata-containers#1930)
738eb6b fix minor typos and remove grpc.Codec related code in TestInterceptorCanAccessCallOptions (kata-containers#1929)
211a7b7 credentials/alts: Update ALTS "New" APIs (kata-containers#1921)
fa28bef client: export types implementing CallOptions for access by interceptors (kata-containers#1902)
ec9275b travis: add Go 1.10 and run vet there instead of 1.9 (kata-containers#1913)
13975c0 stream: split per-attempt data from clientStream (kata-containers#1900)
2c2d834 stats: add BeginTime to stats.End (kata-containers#1907)
3a9e1ba Reset ping strike counter right before sending out data. (kata-containers#1905)
90dca43 resolver: always fall back to default resolver when target does not follow URI scheme (kata-containers#1889)
9aba044 server: Convert all non-status errors to codes.Unknown (kata-containers#1881)
efcc755 credentials/alts: change ALTS protos to match the golden version (kata-containers#1908)
0843fd0 credentials/alts: fix infinite recursion bug [in custom error type] (kata-containers#1906)
207e276 Fix test race: Atomically access minConnecTimout in testing environment. (kata-containers#1897)
3ae2a61 interop: Add use_alts flag to client and server binaries (kata-containers#1896)
5190b06 ALTS: Simplify "New" APIs (kata-containers#1895)
7c5299d Fix flaky test: TestCloseConnectionWhenServerPrefaceNotReceived (kata-containers#1870)
f0a1202 examples: Replace context.Background with context.WithTimeout (kata-containers#1877)
a1de3b2 alts: Change ALTS proto package name (kata-containers#1886)
2e7e633 Add ALTS code (kata-containers#1865)
583a630 Expunge error codes that shouldn't be returned from library (kata-containers#1875)
2759199 Small spelling fixes (unknow -> unknown) (kata-containers#1868)
12da026 clientconn: fix a typo in GetMethodConfig documentation (kata-containers#1867)
dfa1834 Change version to 1.11.0-dev (kata-containers#1863)
46fd263 benchmarks: add flag to benchmain to use bufconn instead of network (kata-containers#1837)
3926816 addrConn: Report underlying connection error in RPC error (kata-containers#1855)
445b728 Fix data race in TestServerGoAwayPendingRPC (kata-containers#1862)
e014063 addrConn: keep retrying even on non-temporary errors (kata-containers#1856)
484b3eb transport: fix race causing flow control discrepancy when sending messages over server limit (kata-containers#1859)
6c48c7f interop test: Expect io.EOF from stream.Send() (kata-containers#1858)
08d6261 metadata: provide AppendToOutgoingContext interface (kata-containers#1794)
d50734d Add status.Convert convenience function (kata-containers#1848)
365770f streams: Stop cleaning up after orphaned streams (kata-containers#1854)
7646b53 transport: support stats.Handler in serverHandlerTransport (kata-containers#1840)
104054a Fix connection drain error message (kata-containers#1844)
d09ec43 Implement unary functionality using streams (kata-containers#1835)
37346e3 Revert "Add WithResolverUserOptions for custom resolver build options" (kata-containers#1839)
424e3e9 Stream: do not cancel ctx created with service config timeout (kata-containers#1838)
f9628db Fix lint error and typo (kata-containers#1843)
0bd008f stats: Fix bug causing trailers-only responses to be reported as headers (kata-containers#1817)
5769e02 transport: remove unnecessary rstReceived (kata-containers#1834)
0848a09 transport: remove redundant check of stream state in Write (kata-containers#1833)
c22018a client: send RST_STREAM on client-side errors to prevent server from blocking (kata-containers#1823)
82e9f61 Use keyed fields for struct initializers (kata-containers#1829)
5ba054b encoding: Introduce new method for registering and choosing codecs (kata-containers#1813)
4f7a2c7 compare atomic and mutex performance in case of contention. (kata-containers#1788)
b71aced transport: Fix a data race when headers are received while the stream is being closed (kata-containers#1814)
46bef23 Write should fail when the stream was done but context wasn't cancelled. (kata-containers#1792)
10598f3 Explain target format in DialContext's documentation (kata-containers#1785)
08b7bd3 gzip: add Name const to avoid typos in usage (kata-containers#1804)
8b02d69 remove .please-update (kata-containers#1800)
1cd2346 Documentation: update broken wire.html link in metadata package. (kata-containers#1791)
6913ad5 Document that all errors from RPCs are status errors (kata-containers#1782)
8a8ac82 update const order (kata-containers#1770)
e975017 Don't set reconnect parameters when the server has already responded. (kata-containers#1779)
7aea499 credentials: return Unavailable instead of Internal for per-RPC creds errors (kata-containers#1776)
c998149 Avoid copying headers/trailers in unary RPCs unless requested by CallOptions (kata-containers#1775)
8246210 Update version to 1.10.0-dev (kata-containers#1777)
17c6e90 compare atomic and mutex performance for incrementing/storing one variable (kata-containers#1757)
65c901e Fix flakey test. (kata-containers#1771)
7f2472b grpclb: Remove duplicate init() (kata-containers#1764)
09fc336 server: fix bug preventing Serve from exiting when Listener is closed (kata-containers#1765)
035eb47 Fix TestGracefulStop flakiness (kata-containers#1767)
2720857 server: fix race between GracefulStop and new incoming connections (kata-containers#1745)
0547980 Notify parent ClientConn to re-resolve in grpclb (kata-containers#1699)
e6549e6 Add dial option to set balancer (kata-containers#1697)
6610f9a Fix test: Data race while resetting global var. (kata-containers#1748)
f4b5237 status: add Code convenience function (kata-containers#1754)
47bddd7 vet: run golint on _string files (kata-containers#1749)
45088c2 examples: fix concurrent map accesses in route_guide server (kata-containers#1752)
4e393e0 grpc: fix deprecation comments to conform to standard (kata-containers#1691)
0b24825 Adjust keepalive paramenters in the test such that scheduling delays don't cause false failures too often. (kata-containers#1730)
f9390a7 fix typo (kata-containers#1746)
6ef45d3 fix stats flaky test (kata-containers#1740)
98b17f2 relocate check for shutdown in ac.tearDown() (kata-containers#1723)
5ff10c3 fix flaky TestPickfirstOneAddressRemoval (kata-containers#1731)
2625f03 bufconn: allow readers to receive data after writers close (kata-containers#1739)
b0e0950 After sending second goaway close conn if idle. (kata-containers#1736)
b8cf13e Make sure all goroutines have ended before restoring global vars. (kata-containers#1732)
4742c42 client: fix race between server response and stream context cancellation (kata-containers#1729)
8fba5fc In gracefull stop close server transport only after flushing status of the last stream. (kata-containers#1734)
d1fc8fa Deflake tests that rely on Stop() then Dial() not reconnecting (kata-containers#1728)
dba60db Switch balancer to grpclb when at least one address is grpclb address (kata-containers#1692)
ca1b23b Update CONTRIBUTING.md to CNCF CLA
2941ee1 codes: Add UnmarshalJSON support to Code type (kata-containers#1720)
ec61302 naming: Fix build constraints for go1.6 and go1.7 (kata-containers#1718)
b8191e5 remove stringer and go generate (kata-containers#1715)
ff1be3f Add WithResolverUserOptions for custom resolver build options (kata-containers#1711)
580defa Fix grpc basics link in route_guide example (kata-containers#1713)
b7dc71e Optimize codes.String() method using a switch instead of a slice of indexes (kata-containers#1712)
1fc873d Disable ccBalancerWrapper when it is closed (kata-containers#1698)
bf35f1b Refactor roundrobin to support custom picker (kata-containers#1707)
4308342 Change parseTimeout to not handle non-second durations (kata-containers#1706)
be07790 make load balancing policy name string case-insensitive (kata-containers#1708)
cd563b8 protoCodec: avoid buffer allocations if proto.Marshaler/Unmarshaler (kata-containers#1689)
61c6740 Add comments to ClientConn/SubConn interfaces to indicate new methods may be added (kata-containers#1680)
ddbb27e client: backoff before reconnecting if an HTTP2 server preface was not received (kata-containers#1648)
a4bf341 use the request context with net/http handler (kata-containers#1696)
c6b4608 transport: fix race sending RPC status that could lead to a panic (kata-containers#1687)
00383af Fix misleading default resolver scheme comments (kata-containers#1703)
a62701e Eliminate data race in ccBalancerWrapper (kata-containers#1688)
1e1a47f Re-resolve target when one connection becomes TransientFailure (kata-containers#1679)
2ef021f New grpclb implementation (kata-containers#1558)
10873b3 Fix panics on balancer and resolver updates (kata-containers#1684)
646f701 Change version to 1.9.0-dev (kata-containers#1682)

Fixes: kata-containers#307

Signed-off-by: Peng Tao <bergwolf@gmail.com>
@jodh-intel
Copy link

jodh-intel commented Jun 24, 2019

/retest

@raravena80
Copy link
Member

raravena80 commented Jun 27, 2019

/test

@jcvenegas
Copy link
Member

jcvenegas commented Jul 26, 2019

update on this: cri-containerd test break the CI as it does pkill containerd but continerd is also used by docker. A new fix is cri-containerd but a new release of containerd with those changes are needed.

The containerd needs to vendor a version with containerd/cri@199ee36

@Random-Liu @chavafg

@grahamwhaley
Copy link
Contributor

grahamwhaley commented Aug 8, 2019

@chavafg @jcvenegas - are we stuck on this one? Maybe mark as WIP or DNM (to avoid reviewers visiting it in the meantime...)

@chavafg
Copy link
Contributor Author

chavafg commented Aug 8, 2019

yeah, sorry, adding labels.
we need to wait for containerd/containerd project to include the cri commit that @jcvenegas mentioned above in a new release.

@chavafg chavafg added the do-not-merge PR has problems or depends on another label Aug 8, 2019
@raravena80
Copy link
Member

raravena80 commented Nov 15, 2019

@chavafg any updates on this PR? Thx. Maybe we should use a newer Docker version.

@chavafg
Copy link
Contributor Author

chavafg commented Nov 15, 2019

yeah, I think we can use 19.03, will take a look next week.

@chavafg chavafg force-pushed the topic/update-docker branch from db9660f to f87b51c Compare November 20, 2019 16:38
@chavafg
Copy link
Contributor Author

chavafg commented Nov 20, 2019

/test

@chavafg chavafg changed the title versions: Update docker to 18.09 versions: Update docker to 19.03 Nov 22, 2019
@chavafg chavafg force-pushed the topic/update-docker branch from f87b51c to e744b7e Compare November 25, 2019 15:07
chavafg added a commit to chavafg/tests-1 that referenced this pull request Nov 25, 2019
@chavafg
ci: Make sure docker is running before running the containerd
2eacb4d 
tests, as some tests need to download images via docker.

Fixes: kata-containers#2118.

Depends-on: github.com/kata-containers/runtime#1715

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
chavafg added a commit to chavafg/tests-1 that referenced this pull request Nov 25, 2019
@chavafg
ci: Ensure docker is running before containerd-cri tests run
d5f5d47 
containerd-cri integration tests need docker as some tests
need to download images.

Fixes: kata-containers#2118.

Depends-on: github.com/kata-containers/runtime#1715

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg chavafg mentioned this pull request Nov 25, 2019
Closed
@chavafg
versions: Update docker to 19.03
084c485 
Move our supported docker version to the latest
available.

For ppc64le, still use v18.06 as 19.03 is currently
not availabele.

For testing with firecracker we als need 18.06 as it is
the last one with block storage support.

Fixes: kata-containers#1110.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg chavafg force-pushed the topic/update-docker branch from e744b7e to 084c485 Compare November 25, 2019 17:41
chavafg added a commit to chavafg/tests-1 that referenced this pull request Nov 25, 2019
@chavafg
ci: Ensure docker is running before containerd-cri tests run
d35a7ae 
containerd-cri integration tests need docker as some tests
need to download images.

Fixes: kata-containers#2118.

Depends-on: github.com/kata-containers/runtime#1715

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
chavafg added a commit to chavafg/tests-1 that referenced this pull request Nov 25, 2019
@chavafg
ci: Ensure docker is running before containerd-cri tests run
befc3df 
containerd-cri integration tests need docker as some tests
need to download images.

Fixes: kata-containers#2118.

Depends-on: github.com/kata-containers/runtime#1715

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
chavafg
chavafg commented Nov 27, 2019
View reviewed changes
versions.yaml
meta:
swarm-version: "1.12.1"
# Latest docker on the ppc64 repos is this one:
ppc64le-version: "v18.06-ce"
Copy link
Contributor Author

@chavafg chavafg Nov 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitkon can you please confirm that this is the case for PowerPC?

chavafg added a commit to chavafg/tests-1 that referenced this pull request Nov 27, 2019
@chavafg
ci: Ensure docker is running before containerd-cri tests run
bda0075 
containerd-cri integration tests need docker as some tests
need to download images.

Fixes: kata-containers#2118.

Depends-on: github.com/kata-containers/runtime#1715

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg
Copy link
Contributor Author

chavafg commented Dec 3, 2019

blocked on #2314.

@fidencio
Copy link
Member

fidencio commented May 3, 2021

As this PR is marked as do-not-merge, we're assuming it won't make for the final 1.13.0 release, thus we're closing it.
In case you feel this has been wrongly closed, please, feel free to re-open it.

@fidencio fidencio closed this May 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@grahamwhaley grahamwhaley grahamwhaley approved these changes

@devimc devimc devimc approved these changes

@jodh-intel jodh-intel jodh-intel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

do-not-merge PR has problems or depends on another

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

update supported docker version

10 participants

@chavafg @grahamwhaley @GabyCT @amshinde @egernst @jodh-intel @raravena80 @jcvenegas @fidencio @devimc