Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

ci: Build kata-runtime before running static checks#1717

Merged
devimc merged 1 commit intokata-containers:masterfrom
chavafg:topic/fix-static-checks
May 21, 2019
Merged

ci: Build kata-runtime before running static checks#1717
devimc merged 1 commit intokata-containers:masterfrom
chavafg:topic/fix-static-checks

Conversation

@chavafg
Copy link
Contributor

@chavafg chavafg commented May 21, 2019

We need to build kata-runtime to have the correct files
in place to be able to run the static checks script.

Fixes #1716.

Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com

@chavafg
Copy link
Contributor Author

chavafg commented May 21, 2019

/test

source "${cidir}/lib.sh"

# Build kata-runtime before running static checks
(cd "${cidir}/../" && make)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make -C "${cidir}/../" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, fixed.

We need to build kata-runtime to have the correct files
in place to be able to run the static checks script.

Fixes kata-containers#1716.

Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
@chavafg chavafg force-pushed the topic/fix-static-checks branch from ed89b57 to 0d98e24 Compare May 21, 2019 17:00
@nitkon
Copy link
Contributor

nitkon commented May 21, 2019

/retest

@chavafg
Copy link
Contributor Author

chavafg commented May 21, 2019

/test-power

@devimc devimc merged commit e2d894d into kata-containers:master May 21, 2019
This was referenced Jun 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

static checks broken

5 participants