This repository was archived by the owner on May 12, 2021. It is now read-only.
data/kata-collect-data: support kata containers snap#1721
Merged
jodh-intel merged 1 commit intokata-containers:masterfrom May 24, 2019
Merged
data/kata-collect-data: support kata containers snap#1721jodh-intel merged 1 commit intokata-containers:masterfrom
jodh-intel merged 1 commit intokata-containers:masterfrom
Conversation
Use `kata-containers.runtime` that is the runtime binary, to collect the data if the kata-runtime binary is not installed fixes kata-containers#1720 Signed-off-by: Julio Montes <julio.montes@intel.com>
|
/test |
grahamwhaley
approved these changes
May 22, 2019
Contributor
grahamwhaley
left a comment
grahamwhaley
left a comment
There was a problem hiding this comment.
lgtm
Yeah, and this gets more complex if we add the static builds in with kata-qemu, kata-fc and maybe kata-nemu coming along as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
kata-containers.runtimethat is the runtime binary, tocollect the data if the kata-runtime binary is not installed
fixes #1720
Signed-off-by: Julio Montes julio.montes@intel.com