fc-toml: remove proxy section in config#1762
fc-toml: remove proxy section in config#1762ganeshmaharaj merged 1 commit intokata-containers:masterfrom
Conversation
|
/test |
grahamwhaley
left a comment
There was a problem hiding this comment.
that was easy :-)
lgtm
proxy will never be use with the Firecracker VMM. Keeping this header will result in runtime failures, since the configuration will be parsed on the path searched for. Since vsock will always be used, remove the proxy section. Fixes: kata-containers#1761 Signed-off-by: Eric Ernst <eric.ernst@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #1762 +/- ##
=======================================
Coverage 53.93% 53.93%
=======================================
Files 106 106
Lines 13126 13126
=======================================
Hits 7080 7080
Misses 5202 5202
Partials 844 844 |
|
rekicking ubuntu CI... |
|
ARM build seems to be failing with this. Not sure how we can control which machine on packet this PR might land. |
|
@ganeshmaharaj @Pennyzct @chavafg - if we now have two different packet ARM Jenkins slaves with different feature sets, then we probably cannot, and do not want to, dictate which slave the job lands on... the code in the repo should handle and work on both imo, no? |
proxy will never be use with the Firecracker VMM. Keeping this header
will result in runtime failures, since the configuration will be parsed
on the path searched for.
Since vsock will always be used, remove the proxy section.
Fixes: #1761
Signed-off-by: Eric Ernst eric.ernst@intel.com