Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

fc-toml: remove proxy section in config#1762

Merged
ganeshmaharaj merged 1 commit intokata-containers:masterfrom
egernst:fix-1761
Jun 4, 2019
Merged

fc-toml: remove proxy section in config#1762
ganeshmaharaj merged 1 commit intokata-containers:masterfrom
egernst:fix-1761

Conversation

@egernst
Copy link
Member

@egernst egernst commented Jun 4, 2019

proxy will never be use with the Firecracker VMM. Keeping this header
will result in runtime failures, since the configuration will be parsed
on the path searched for.

Since vsock will always be used, remove the proxy section.

Fixes: #1761

Signed-off-by: Eric Ernst eric.ernst@intel.com

@egernst
Copy link
Member Author

egernst commented Jun 4, 2019

/test

Copy link
Contributor

@grahamwhaley grahamwhaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was easy :-)
lgtm

proxy will never be use with the Firecracker VMM. Keeping this header
will result in runtime failures, since the configuration will be parsed
on the path searched for.

Since vsock will always be used, remove the proxy section.

Fixes: kata-containers#1761

Signed-off-by: Eric Ernst <eric.ernst@intel.com>
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #1762 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1762   +/-   ##
=======================================
  Coverage   53.93%   53.93%           
=======================================
  Files         106      106           
  Lines       13126    13126           
=======================================
  Hits         7080     7080           
  Misses       5202     5202           
  Partials      844      844

@egernst
Copy link
Member Author

egernst commented Jun 4, 2019

rekicking ubuntu CI...

@ganeshmaharaj
Copy link
Contributor

ARM build seems to be failing with this.

10:19:39 Running command '/usr/local/bin/kata-runtime [kata-runtime --log=/tmp/bundle118142353/log run --bundle=/tmp/bundle118142353 --console= --pid-file=/tmp/bundle118142353/pid --detach iT1jFZZxSMw0qqeS7V0d]'
10:19:40 command failed error 'exit status 1'
10:19:40 [kata-runtime --log=/tmp/bundle118142353/log run --bundle=/tmp/bundle118142353 --console= --pid-file=/tmp/bundle118142353/pid --detach iT1jFZZxSMw0qqeS7V0d]
10:19:40 Timeout: 120 seconds
10:19:40 Exit Code: 1
10:19:40 Stdout: 
10:19:40 Stderr: qemu-system-aarch64: This host does not support 42b IPA: maxram/slots options not usable
10:19:40 
10:19:40 

Not sure how we can control which machine on packet this PR might land.

@ganeshmaharaj ganeshmaharaj merged commit c433580 into kata-containers:master Jun 4, 2019
@grahamwhaley
Copy link
Contributor

@ganeshmaharaj @Pennyzct @chavafg - if we now have two different packet ARM Jenkins slaves with different feature sets, then we probably cannot, and do not want to, dictate which slave the job lands on... the code in the repo should handle and work on both imo, no?
But, having said that, I am concerned that we might land code that passes the CI on one of the slaves, but would have failed on the other. Maybe having disparate machines with different features means we should really run parallel ARM CI jobs to test both machine types for each PR? :-(

@egernst egernst deleted the fix-1761 branch June 26, 2020 05:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Firecracker toml result in failure to boot

4 participants