Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

upgrade vendor ttrpc#2045

Merged
GabyCT merged 1 commit intokata-containers:masterfrom
lifupan:fix_ttrpc_fd_leak
Sep 12, 2019
Merged

upgrade vendor ttrpc#2045
GabyCT merged 1 commit intokata-containers:masterfrom
lifupan:fix_ttrpc_fd_leak

Conversation

@lifupan
Copy link
Member

@lifupan lifupan commented Sep 12, 2019

Upgrade vendor ttrpc to fix the issue of
fd leak.

Fixes: #2000

0e0f228 Handle ok status
8c74fe8 Update to go 1.12x on travis
17f4d32 Client.Call(): do not return error if no Status is set (gRPC v1.23 and up)
271238a Fix method full name generation
694de9d metadata as KeyValue type
3afb82b Fix error handling with server shutdown
f3eb35b Refactor close handling for ttrpc clients
de8faac Add godocs for interceptors
e409d7d Add example binary for testing the example service
819653f Add client and server unary interceptors
04523b9 Rename headers to metadata
5926a92 Support headers
911c9cd Improve connection error handling
96dcf73 Handle EOF to prevent file descriptor leak
ba15956 Make onclose an option.

Signed-off-by: lifupan <fupan.lfp@@antfin.com>

@lifupan
Copy link
Member Author

lifupan commented Sep 12, 2019

/test

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@39864c3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2045   +/-   ##
=========================================
  Coverage          ?   51.67%           
=========================================
  Files             ?      107           
  Lines             ?    14615           
  Branches          ?        0           
=========================================
  Hits              ?     7552           
  Misses            ?     6152           
  Partials          ?      911

Upgrade vendor ttrpc to fix the issue of fd leak.

Fixes: kata-containers#2000

    0e0f228 Handle ok status
    8c74fe8 Update to go 1.12x on travis
    17f4d32 Client.Call(): do not return error if no Status is set(gRPC v1.23 and up)
    271238a Fix method full name generation
    694de9d metadata as KeyValue type
    3afb82b Fix error handling with server shutdown
    f3eb35b Refactor close handling for ttrpc clients
    de8faac Add godocs for interceptors
    e409d7d Add example binary for testing the example service
    819653f Add client and server unary interceptors
    04523b9 Rename headers to metadata
    5926a92 Support headers
    911c9cd Improve connection error handling
    96dcf73 Handle EOF to prevent file descriptor leak
    ba15956 Make onclose an option.

Signed-off-by: lifupan <lifupan@gmail.com>
@lifupan
Copy link
Member Author

lifupan commented Sep 12, 2019

/test

Copy link

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lifupan.

lgtm

@GabyCT GabyCT merged commit 4d74fa1 into kata-containers:master Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade ttrpc to avoid fd leak

5 participants