Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

virtcontainers: Don't create vfio devices in the guest#2550

Merged
devimc merged 1 commit into
kata-containers:masterfrom
devimc:topic/virtcontainers/noVFIOInGuest
Mar 24, 2020
Merged

virtcontainers: Don't create vfio devices in the guest#2550
devimc merged 1 commit into
kata-containers:masterfrom
devimc:topic/virtcontainers/noVFIOInGuest

Conversation

@devimc
Copy link
Copy Markdown

@devimc devimc commented Mar 23, 2020

vfio devices hotplugged in the VM are expected to be handled by the kernel
driver in the guest, hence the char vfio devices shouldn't appear in the
container under /dev/vfio/.

fixes #2539

Signed-off-by: Julio Montes julio.montes@intel.com

vfio devices hotplugged in the VM are expected to be handled by the kernel
driver in the guest, hence the char vfio devices shouldn't appear in the
container under /dev/vfio/.

fixes kata-containers#2539

Signed-off-by: Julio Montes <julio.montes@intel.com>
@devimc
Copy link
Copy Markdown
Author

devimc commented Mar 23, 2020

@amorenoz please take a look, this should fix #2539

@devimc
Copy link
Copy Markdown
Author

devimc commented Mar 23, 2020

/test-ubuntu

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@078da1a). Click here to learn what that means.
The diff coverage is 85.71%.

@@            Coverage Diff            @@
##             master    #2550   +/-   ##
=========================================
  Coverage          ?   50.57%           
=========================================
  Files             ?      116           
  Lines             ?    16851           
  Branches          ?        0           
=========================================
  Hits              ?     8522           
  Misses            ?     7293           
  Partials          ?     1036

@lifupan
Copy link
Copy Markdown
Member

lifupan commented Mar 24, 2020

/test

Copy link
Copy Markdown

@jodh-intel jodh-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devimc.

lgtm

@devimc devimc merged commit 213f5db into kata-containers:master Mar 24, 2020
@amshinde
Copy link
Copy Markdown
Member

@devimc Does this need to be backported to 1.10?

@devimc
Copy link
Copy Markdown
Author

devimc commented Apr 15, 2020

@amshinde yes, @chavafg already backport it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vfio: Host's vfio char device appers on guest

5 participants