This repository was archived by the owner on May 12, 2021. It is now read-only.
qemu: Don't crash if virtiofsd path is non existent#2583
Merged
Conversation
fidencio
force-pushed
the
wip/virtiofsd_not_present
branch
from
e4efebd to
d347b20
Compare
Contributor
|
/test |
Codecov Report
@@ Coverage Diff @@
## master #2583 +/- ##
=========================================
Coverage ? 50.46%
=========================================
Files ? 118
Lines ? 17018
Branches ? 0
=========================================
Hits ? 8588
Misses ? 7389
Partials ? 1041 |
devimc
reviewed
Apr 3, 2020
Instead, report an error and exit gracefully, as shown below: ``` dahmer fidencio # podman run -ti --runtime=/usr/bin/kata-runtime fedora sh Error: virtiofsd path (/usr/libexec/virtiofsd) does not exist: OCI runtime error ``` Fixes: kata-containers#2582 Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com>
fidencio
force-pushed
the
wip/virtiofsd_not_present
branch
from
d347b20 to
fd625b3
Compare
devimc
approved these changes
Apr 3, 2020
jodh-intel
approved these changes
Apr 3, 2020
|
/test |
Member
Author
|
The two CI failures are well known and not related to this patch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, report an error and exit gracefully, as shown below:
Fixes: #2582
Signed-off-by: Fabiano Fidêncio fidencio@redhat.com