This repository was archived by the owner on May 12, 2021. It is now read-only.
versions: move to go 1.10#260
Merged
jodh-intel merged 3 commits intokata-containers:masterfrom Apr 27, 2018
Merged
Conversation
jcvenegas
force-pushed
the
go1.10
branch
2 times, most recently
from
66f04e9 to
9610d07
Compare
Now that our CI has moved to Go 1.10, we need to update one file that is not formatted as the new gofmt (1.10) expects it to be formatted. Fixes kata-containers#249 Signed-off-by: Sebastien Boeuf <sebastien.boeuf@intel.com>
Update covertool to allow run tests with go 1.10 Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
=======================================
Coverage 65.35% 65.35%
=======================================
Files 74 74
Lines 7892 7892
=======================================
Hits 5158 5158
Misses 2180 2180
Partials 554 554Continue to review full report at Codecov.
|
jcvenegas
changed the title
Member
Author
|
Hit two random issues: not ok 20 ctr execsync std{out,err} |
Member
Author
|
restating all jobs. |
Change the latest working go version for kata. Signed-off-by: Jose Carlos Venegas Munoz <jose.carlos.venegas.munoz@intel.com>
Member
Author
|
@sboeuf @jodh-intel @devimc @bergwolf ready to merge all jobs passing with go 1.10 Tested in agent, proxy and shim CI as well. All looks ok. |
|
Thanks @jcvenegas! lgtm For reference, the go 1.10 PRs for the other components: |
devimc
approved these changes
Apr 27, 2018
zklei
pushed a commit
to zklei/runtime
that referenced
this pull request
Jun 13, 2019
agent: update container cpuset cgroup parents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.